Giter Site home page Giter Site logo

Comments (10)

voronianski avatar voronianski commented on July 19, 2024

@miguelleite is that tested on Windows?

from ngdialog.

miguelleite avatar miguelleite commented on July 19, 2024

yep, using Windows 8.1, Chrome v35.0.1916.153 m.
Also tested on:

  • Opera v22.0.1471.70
  • Firefox v30.0
  • Safari for Windows v5.1.7.

from ngdialog.

miguelleite avatar miguelleite commented on July 19, 2024

in your demo page, it looks good with the fixed background, but if we reduce the window to a really small size, where the vertical space is not enough for the content and the scroll shows, if we open the dialog you can see it happen.

from ngdialog.

miguelleite avatar miguelleite commented on July 19, 2024

https://dl.dropboxusercontent.com/u/5886046/ngDialog.gif

from ngdialog.

miguelleite avatar miguelleite commented on July 19, 2024

Well, I solved this by doing the following:

Make html and body 100% height via-CSS:

html, body {
    height: 100%;
}

Then I forced my body element to hide all the overflowing content:

body {
    overflow: hidden !important;
}

Then I created a .whole-container div, right below the body, and moved all my body content to this div.

Via-CSS, I added the following styles:

.whole-container {
    overflow-y: scroll;
    height: 100%;
    max-height: 100%;
    display: block;
    position: relative;
}

Also, this disables the background scroll, which looks very nice. When we've got a popup opened, we want the users focused on that popup and not in the background. :)

from ngdialog.

voronianski avatar voronianski commented on July 19, 2024

@miguelleite it should be fixed in version 0.2.5 and higher.

from ngdialog.

shuhankuang avatar shuhankuang commented on July 19, 2024

I use 0.3.0, I also get the background scroll.
anything I miss?

from ngdialog.

deweydb avatar deweydb commented on July 19, 2024

@miguelleite Thanks! nice fix!

from ngdialog.

mklkht avatar mklkht commented on July 19, 2024

Also waiting for fix

from ngdialog.

ben-crowhurst avatar ben-crowhurst commented on July 19, 2024

+1

from ngdialog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.