Comments (10)
@miguelleite is that tested on Windows?
from ngdialog.
yep, using Windows 8.1, Chrome v35.0.1916.153 m.
Also tested on:
- Opera v22.0.1471.70
- Firefox v30.0
- Safari for Windows v5.1.7.
from ngdialog.
in your demo page, it looks good with the fixed background, but if we reduce the window to a really small size, where the vertical space is not enough for the content and the scroll shows, if we open the dialog you can see it happen.
from ngdialog.
from ngdialog.
Well, I solved this by doing the following:
Make html and body 100% height via-CSS:
html, body {
height: 100%;
}
Then I forced my body element to hide all the overflowing content:
body {
overflow: hidden !important;
}
Then I created a .whole-container
div, right below the body, and moved all my body content to this div.
Via-CSS, I added the following styles:
.whole-container {
overflow-y: scroll;
height: 100%;
max-height: 100%;
display: block;
position: relative;
}
Also, this disables the background scroll, which looks very nice. When we've got a popup opened, we want the users focused on that popup and not in the background. :)
from ngdialog.
@miguelleite it should be fixed in version 0.2.5
and higher.
from ngdialog.
I use 0.3.0, I also get the background scroll.
anything I miss?
from ngdialog.
@miguelleite Thanks! nice fix!
from ngdialog.
Also waiting for fix
from ngdialog.
+1
from ngdialog.
Related Issues (20)
- Still active? HOT 2
- ngDialog : Uncaught TypeError: Cannot read property 'data' of undefined HOT 2
- The dialog closes when you click on the scrollbar of the browser HOT 3
- Because of Hammer.js horizontal scrolling is not working inside a dialog
- Nested resolves?
- How to prevent page scroll up or down when close the dialog HOT 2
- Sticky Header On Scroll
- NgDialog position to center of parent called inside iframe
- Close the topmost ngDialog Instance
- Want to call ngDialog in $provide.decorator('$exceptionHandler',
- Need support for full screen dialog modal
- [Question] Draggable modal HOT 1
- ngDialog.open doesn't work with a script tag, only with an external html file HOT 1
- Setting a controller doesn't work with angular 1.7.1 HOT 1
- need to decrease the z-index of the ngDialog..help would be appreciated. HOT 1
- Hammer JS, tap on close button triggered click event on element behind the dialog box
- AngularJs 1.7, on every route change the dialogs are incrementing. every time you come back to the controller the dialogs will be 1,2,3,4 and so on HOT 4
- ngDialog controllerAs not working when upgrade ngdialog version to 0.6.6
- How is it possible to bind data back to $scope from the $scope changes made within the dialog?
- How to close dialog opened by openConfirm HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngdialog.