Giter Site home page Giter Site logo

Get wrong $body about ngdialog HOT 4 CLOSED

likeastore avatar likeastore commented on August 19, 2024
Get wrong $body

from ngdialog.

Comments (4)

voronianski avatar voronianski commented on August 19, 2024

@yimingliu0216 could you please provide some fiddle or demo to check your example? I've got your point but would like to check the specific case.

from ngdialog.

toponsky avatar toponsky commented on August 19, 2024

@voronianski thanks for the reply, here is my scenario :

We have submit and detail buttons in an item tile and a controller associate with it. When the button is pressed, the controller sends a require to server. If server return a failure, the controller call ngDialog.open to show a error message.

The tile has been used in two pages (item overview and detail). Overview page is loading page, so it always loaded in app beginning. User presses detail button to go to detail page, We use $location.path('details') to redirect to detail page.

The issue is ngDialog.open works fine in overview page (only first time loading). ngDialog.open doesn't work in detail page and doesn't work in overview page when the page is redirect back from detail page.

from ngdialog.

voronianski avatar voronianski commented on August 19, 2024

@yimingliu0216 I'm not sure but it might be something wrong with your code or project setup.. in most cases you shouldn't reload body in angular app.. I'm using ngDialog in a couple of projects with many routes that are changing also with $location service sometimes but there were no such problem.

Caching body is nice due to performance, of course it's not a problem to add additional option to force body reload everytime or do it on $locationChangeSuccess event, but it smells like not right way that may occure in some rare cases.

Could you provide a demo or fiddle that represents the basic idea of the problem? Or maybe just share code?

from ngdialog.

voronianski avatar voronianski commented on August 19, 2024

@yimingliu0216 if this is still relevant for you use setForceBodyReload method starting from version 0.2.7 - https://github.com/likeastore/ngDialog#setforcebodyreloadboolean

from ngdialog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.