Giter Site home page Giter Site logo

Comments (8)

voronianski avatar voronianski commented on July 1, 2024

@noosxe what version do you use? and how do you initialize the dialog (code examples will be helpful)?

from ngdialog.

noosxe avatar noosxe commented on July 1, 2024

@voronianski I use version 0.3.0

I configure it as:

ngDialogProvider.setDefaults({
  className: 'ngdialog-theme-plain',
  plain: false,
  showClose: true,
  closeByDocument: false,
  closeByEscape: false,
  appendTo: false
});

And open the dialog:

ngDialog.open({
  template: 'mytemplateid',
  controller: 'mytemplatecontroller',
  preCloseCallback: function() {
    // some actions here
  }
});

I close the dialog by clicking on 'x' button.

from ngdialog.

voronianski avatar voronianski commented on July 1, 2024

@noosxe I cannot reproduce this.. I assume something is wrong with your app configuration..

that's how my test app with your presets looks:

var app = angular.module('exampleDialog', ['ngDialog']);

// Example of how to set default values for all dialogs
app.config(['ngDialogProvider', function (ngDialogProvider) {
    ngDialogProvider.setDefaults({
        className: 'ngdialog-theme-plain',
        plain: false,
        showClose: true,
        closeByDocument: false,
        closeByEscape: false
    });
}]);

app.controller('MainCtrl', function ($scope, $rootScope, ngDialog) {
    $scope.open = function () {
        ngDialog.open({
            template: 'firstDialogId',
            controller: 'InsideCtrl',
            preCloseCallback: function () {
                console.log('callback');
            }
        });
    };
});

app.controller('InsideCtrl', function ($scope, ngDialog) {
    $scope.openSecond = function () {
        ngDialog.open({
            template: '<h3>Boo!</h3>',
            plain: true,
            closeByEscape: true
        });
    };
});

from ngdialog.

noosxe avatar noosxe commented on July 1, 2024

I found out what caused that problem,
In my app config I do

$compileProvider.debugInfoEnabled(false);

After removing that dialog started to close properly.

from ngdialog.

voronianski avatar voronianski commented on July 1, 2024

@noosxe do you use ngDialog with Angular 1.3?

from ngdialog.

noosxe avatar noosxe commented on July 1, 2024

Yes angular 1.3.0-rc.0

from ngdialog.

voronianski avatar voronianski commented on July 1, 2024

@noosxe ngDialog is not updated to work with not-stable 1.3 yet, so in order to avoid unexpected bugs use stable Angular version 1.2.

from ngdialog.

watzak avatar watzak commented on July 1, 2024

@noosxe : Thank u for finding out what caused the issue, u saved my day today ;)
$compileProvider.debugInfoEnabled(false); was causing the issue

from ngdialog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.