Comments (6)
@2tunnels hi! it sounds ok, but your custom_renderer
is already implemented as httpserver mode
:)
It can be a minor feature in the future, but I don't see any reason to implement it right now. People usually uses one of the three modes and if they use something custom, the just implement their server for httpserver mode
. I want to keep the library as simple and small as possible.
from django-mjml.
Yes, but HTTP server implementation is hardcoded. Let's say I want to use protobuf
instead of JSON, or my request body looks a little different. Or I want to do custom authentication with another header.
This feature will not break anything because it's just an additional check (after cmd
, tcpserver
and httpserver
), and the only thing we need to check if this new string is importable and callable.
from django-mjml.
I think it will be better to implement class-based backend pattern. I'll think about it.
from django-mjml.
Sounds good! But will callable
approach you can use both functions and classes (classes that implement __call__
method).
It's your decision, just saying that function is the simplest API abstraction you can have 😇
from django-mjml.
I thing class is better because I want to support multiple backends and one backend will be able to initiate with different settings and it also allow the beckend to use instance variables to use caching, collect stats, keeping connections and so on.
from django-mjml.
If you want to separate configuration and execution steps, yes, class approach makes more sense.
from django-mjml.
Related Issues (20)
- Add support for Django 3.1 HOT 1
- MJML tags not being recognized HOT 3
- How to use with blocks? HOT 1
- MJML compiler in TCP mode failing in CI on bitbucket HOT 10
- Add support for django 3.2 HOT 7
- Mock httpserver HOT 2
- MJML compile error (via MJML TCP server): no working server HOT 6
- Update to support Django 4.0 HOT 4
- Setting necessary for allowing custom authentication/transport for http backend HOT 5
- Does mjml support blocks in templates ? HOT 1
- Possibility to render *.mjml templates to *.html templates HOT 1
- tcpserver.js removed in 1.0 release but is still in docs HOT 2
- Support django 4.2 HOT 1
- django.core.exceptions.ImproperlyConfigured: Problem to run command "mjml -i -s" HOT 1
- Integrate mjml-python? HOT 3
- Support django 5.0 HOT 1
- Message in stderr is breaking django-mjml HOT 7
- mj-include doesn't work HOT 1
- Getting timeouts since 0.8.0 HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-mjml.