Comments (6)
Could you provide more info on the problem?
My understanding is that you have approval requirements on repositories, but not administrator bypassing. What addition to the merge command would resolve this?
from multi-gitter.
Yes. You cannot merge any PR then when not approved.
GitHub API will provide the following error message if you try to do so:
At least 1 approving review is required by reviewers with write access.
To enable merge, a review with approval review action (event=APPROVE) is required.
The GitHub API is documented here:
https://docs.github.com/en/rest/pulls/reviews#create-a-review-for-a-pull-request
https://docs.github.com/en/graphql/reference/input-objects#addpullrequestreviewinput
I think your GO GitHub library supports that:
https://github.com/google/go-github/blob/master/github/pulls_reviews.go
I suggest to make this approval an optional option maybe with some additional review comments which can be provided?
from multi-gitter.
I don't think you can approve your own PR?
Even if you could, this would only work when exactly one required reviewer is set, anything more than that would not work.
from multi-gitter.
I don't think you can approve your own PR?
No you can't. Sorry for being unprecise in my initial description.
This feature would be useful e.g. to bulk approve and merge Dependabot PRs or PRs that somebody else created (with multi-gitter).
If you have the policy that administrators cannot bypass branch protection and use multi-gitter, you'll end up with hundreds of pull request which need to be manually approved and merged.
Even if you could, this would only work when exactly one required reviewer is set, anything more than that would not work.
Valid point, then maybe approval should be a separate command?
from multi-gitter.
This feature would be useful e.g. to bulk approve and merge Dependabot PRs or PRs that somebody else created (with multi-gitter).
Even though the merge/close/status commands can be used on PRs not created by multi-gitter, it's not really the use case. If users use those commands for it, that's fine, but changes will not be made because of it.
then maybe approval should be a separate command?
I think this is the solution if one were to be implemented
But currently, I think this is a special case since the setting, that not even administrators should be able to override a merge indicate that it should indeed not be overridden in any way. And creating a new sub command for this special case is today not relevant. But I'm open to having my mind changed if a lot of people have this use case. I will therefore leave this open and allow others to comment if they have this use case.
from multi-gitter.
Related Issues (20)
- multi-gitter run does not sign commits HOT 13
- Deleting files produces empty commits HOT 8
- You have exceeded a secondary rate limit HOT 9
- Unable to commit to main branch with 'confict-strategy=replace' "A branch named 'main' already exists. HOT 2
- unknown command when using --interactive HOT 1
- Feature request: Github PR labels HOT 3
- Add ability to configure repository clone directory (currently system temp) HOT 3
- Fine-grained personal access tokens not supported by multi-gitter HOT 4
- Installation fails with 404 on Windows HOT 3
- Handle failed merge runs due to branch protection rules more gracefully HOT 5
- Display error in GitLab pipeline log HOT 10
- "unknown escape sequence" when running with --git-type=go HOT 5
- Update branches with changes HOT 2
- Gitlab: Groups need to be urlencoded HOT 5
- introduce new env var DRY_RUN for scripts to be executed HOT 3
- ssh-auth: true is not working , expecting a PAT keys HOT 4
- Replace conflict strategy does not update PR body HOT 1
- Sometimes, .gitignore is not respected and files listed in .gitignore are included in the commits created by multi-gitter HOT 8
- Installation is failed on Linux x64 with version 0.47.1 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from multi-gitter.