Failing builds for Lineage-19.0 due to artifact path requirement

[lineageos4microg]

Failing builds for Lineage-19.0 due to artifact path requirement

[bananer]

There are definitely some apps which are marked as "product" by stock LineageOS like DeskClock and Eleven since product_specific in Android.bp has the same meaning as LOCAL_PRODUCT_MODULE in Android.mk as explained here.

I will make the change on a branch product_modules now and try a few builds for both 18.1 and 19.0.

[bananer]

This change is probably incompatible with Android versions before 9.

[bananer]

XML files still not in the right place:

FAILED:                                           
      build/make/core/artifact_path_requirements.mk:26: warning:  device/google/sunfish/lineage_sunfish.mk produces files inside build/make/target/product/generic_system.mks artifact path requirement.                              Offending entries:                                
      system/etc/org.fdroid.fdroid/additional_repos.xml       
system/etc/permissions/privapp-permissions-com.android.vending.xml                                                                                 
system/etc/permissions/privapp-permissions-com.google.android.gms.xml                                           
system/etc/permissions/privapp-permissions-
org.fdroid.fdroid.privileged.xml                                     
system/etc/sysconfig/sysconfig-com.google.android.gms.xml                                                       
In file included from build/make/core/main.mk:1346:     build/make/core/artifact_path_requirements.mk:26: 
error: Build failed.                                         
 19:18:42 ckati failed with: exit status 1

Probably need to change TARGET_OUT_ETC to TARGET_OUT_PRODUCT_ETC