proxy_build_info git_version label value is the same as git_sha

[dkulchinsky]

proxy_build_info git_version label value is the same as git_sha

[olix0r]

The proxy releases are decoupled from linkerd releases, so the versions would never line up in that way. I agree it would be nice to have better version info

[dkulchinsky]

Thanks @olix0r, so git_version label should display the proxy version? however currently it is equal to the commit sha (same value as git_sha label)

for example:

proxy_build_info{git_branch="HEAD", git_sha="0e843c9", git_version="0e843c9", profile="release", rust_version="rustc 1.69.0 (84c898d65 2023-04-16)", <...>}

git_sha="0e843c9", git_version="0e843c9"

[dkulchinsky]

Hey @olix0r 👋🏼

just wanted to circle back to this again, if I understand your comment correctly then git_version should have the proxy version as value which is not the same as the linkerd version, that makes sense! however as I showed above it that's not the case, the value is the commit sha and is the same same value as git_sha label.

the main issue we have is we can't reasonably track the deployed proxy versions using this metric as the value of git_version is not very usable.

so I think this is still a bug?

[dkulchinsky]

Happy new year @olix0r 👋🏼

Was hoping you'd have a chance to see my last comment, I think aside from the issue you mentioned (that the linkerd version in git_version reflects the proxy version, not the linkerd version) the current value provided in the git_version seem entirely incorrect as it's equal to the value of git_sha

[olix0r]

It looks like we fixed this issue in June linkerd/linkerd2-proxy#2432

Recent proxy build info looks like this:

proxy_build_info{date="2023-12-27T21:31:20Z",git_sha="f191eac",profile="release",vendor="linkerd",version="2.219.0"} 1

[dkulchinsky]

ohh, indeed!

we just upgraded to stable-2.14.8 and I can see the new version label.

closing this now and thanks again for the fix @olix0r