Pierce iframes

[lino-levan]

Pierce iframes

[lino-levan]

Unfortunately, pierce doesn't work the way you hope it would. This could be something interesting to look into though as a default.

[liamdiprose]

Thanks for the heads up. I had a look at the Playwright source, but learnt very little. This stack overflow answer helped me though.

Working celestial code:

const doc = await celestial.DOM.getDocument({ depth: 0 })

const frame_node = await celestial.DOM.querySelector({ nodeId: doc.root.nodeId, selector: "iframe#ed-embedded-iframe" })
const frame_description = await celestial.DOM.describeNode({ nodeId: frame_node.nodeId })
const frame_content_remote_object = await celestial.DOM.resolveNode({ backendNodeId: frame_description.node.contentDocument.backendNodeId })
const frame_content_doc = await celestial.DOM.requestNode({ objectId: frame_content_remote_object.object.objectId })

const frame = new ElementHandle(frame_content_doc.nodeId, celestial, page)

await frame.waitForSelector("#ConfirmFee")

Apparently it doesn't work if the iframe's origin is different; security reasons I guess.

It would be a seamless experience if we found a way to query into iframes transparently, but we would have to understand if a query applies to an iframe or not, then modify it to query inside the iframe. It may cause more pain in the long run.

However, if an ElementHandle is on an iframe, then we can forward the querySelector calls to the 'Frame' without too much complexity.

I'd be interested in helping with this project. Are you accepting PRs?

Cheers,
Liam

[lino-levan]

Always happy to accept PRs. I'm curious on how you're thinking about this.