Use github.com/linode/linodego to use Linode APIv4 and reduce code

[displague]

Use github.com/linode/linodego to use Linode APIv4 and reduce code

[dradtke]

@displague I just pushed a commit to the apiv4 branch that almost gets it working. Unfortunately, the image seems to get cleaned up by Linode almost immediately, and my best guess is that we need to wait until the image is actually done before exiting.

Unfortunately, Linode's v4 API doesn't seem to have any concept of an image status, and the ListNotifications() call is completely broken. Any thoughts about how to solve this?

[displague]

@dradtke Sorry about that, I'll address ListNotifications.

https://github.com/terraform-providers/terraform-provider-linode/blob/master/linode/resource_linode_image.go#L154-L186

Also notice that Create also verifies that the Image still exists when the Instance status has returned to normal. This is because a failed image will be deleted and will no longer be accessible.

https://github.com/terraform-providers/terraform-provider-linode/blob/master/linode/resource_linode_image.go#L111-L124

( @akerl was the contributor behind that )

[displague]

@dradtke https://github.com/linode/linodego/releases/tag/v0.7.1 corrects the notifications bug you discovered.

It's been merged for a while but I hadn't pushed any tags/releases since before Kubecon and holidays.