Relocate RPATH

[sjackman]

Relocate RPATH

[DoomHammer]

I'd say you need to replace /home/linuxbrew/.linuxbrew with $HOMEBREW_PREFIX as well in existing RPATH

[DoomHammer]

patchelf --print-rpath perl/5.22.1/bin/perl
/home/linuxbrew/.linuxbrew/Cellar/perl/5.22.1/lib/5.22.1/x86_64-linux-thread-multi/CORE

vs

patchelf --print-rpath hello/2.10/bin/hello                                                                                                             
@@HOMEBREW_PREFIX@@/lib

[DoomHammer]

Something like #35?

[sjackman]

I'd say you need to replace /home/linuxbrew/.linuxbrew with $HOMEBREW_PREFIX as well in existing RPATH

Yes, that prefix should not exist in bottles, but a few bottles were being built without patchelf installed if they didn't themselves depend on any bottles, and those bottles have the RPATH set to /home/linuxbrew/.linuxbrew/lib rather than @@HOMEBREW_PREFIX@@/lib.

[sjackman]

My plan was to remove any RPATH variables that did not start with @@HOMEBREW_PREFIX@@ and then append $HOMEBREW_PREFIX/lib to the RPATH if it did not already contain it.

[sjackman]

patchelf --print-rpath perl/5.22.1/bin/perl
/home/linuxbrew/.linuxbrew/Cellar/perl/5.22.1/lib/5.22.1/x86_64-linux-thread-multi/CORE

brew install patchelf
brew install --build-bottle perl
brew bottle perl
tar xf perl*bottle*.tar.gz

You should see that all the /home/linuxbrew/.linuxbrew in RPATH and text files have been replaced by @@HOMEBREW_PREFIX@@. It's a bug if not.

[DoomHammer]

Hmm, I'll check if I had patchelf in place when bottling perl.

[DoomHammer]

The missing patchelf was the problem. Shall we allow bottling without patchelf?

[DoomHammer]

Same question about using system gcc?

[sjackman]

Shall we allow bottling without patchelf?

Probably not. It should give an error and exit.

[sjackman]

Same question about using system gcc?

I do want to support using the system gcc. The bottles are built on Ubuntu 14 using glibc 2.19 and gcc 4.8 by design so that those bottles can be run on Ubuntu 14 and newer distros without requiring that they install either Linuxbrew glibc or gcc.

[DoomHammer]

Original issue is no more thanks to #35. Talks about whether patchelf is needed for bottling can be split to separate issue.