quoteOfTheDay@tinnu: doesn't work

[linuxmint]

quoteOfTheDay@tinnu: doesn't work

[JessW]

@Ilis I see, I see. That is totally my fault. I have one more test I want to run before I make the pull request to the main Spices repo, and I just haven't gotten to it yet. Soon, I hope!

Thank you also for your translation, I really appreciate it!

[JessW]

Hi there, could you let me know what version of Mint and Cinnamon you are using? Also, does ~/.cinnamon/glass.log show errors related to this desklet? Thanks!

[Ilis]

Hi, @JessW

ilis@deore ~ $ inxi -xxxSc0 -! 31
System: Kernel: 4.4.0-72-generic x86_64 (64 bit gcc: 5.4.0)
Desktop: Cinnamon 3.2.7 (Gtk 3.18.9-1ubuntu3.3) dm: mdm Distro: Linux Mint 18.1 Serena

~/.cinnamon/glass.log
info t=2017-05-10T17:19:00.515Z Loaded desklet quoteOfTheDay@tinnu in 241 ms
info t=2017-05-10T17:19:00.519Z Cinnamon took 5010 ms to start
no errors

Also, fortunes-ru package installed, if it matter.

[JessW]

Thanks for the info, @Ilis

I don't think I've tested it with Cinnamon 3.2, but I do think it might be a language issue. Do you also have the English fortunes package installed, out of curiosity? I noticed just yesterday that there is a French version of this applet, which is what makes me think this one might not work correctly with other languages. I will check it out when I get a chance, it might be a day or two though!

[JessW]

@Ilis If you can, could you add a screen shot of the configuration window, or let me know the path of the file you have selected? I was able to test the desklet with a randomly selected file from fortunes-ru:
/usr/share/games/fortunes/ru/drink
and it worked, but I am using Cinnamon 3.0.7. I am not quite sure what you mean by "There are no way to unchose file in settings." in your first comment. You should be able to type in the box that displays the path to the file, or use the file selector button next to the box with the path. When I enter a the name of a file that doesn't exist, I do get the behavior you are describing.

I will try to get Cinnamon 3.2 on a spare box as well to see if I can reproduce what you're seeing.

[Ilis]

@JessW ,
I used to chose different files, i. e.
/usr/share/games/fortunes/ru/computer
/usr/share/games/fortunes/literature

“no way to unchose” means that after fresh install no file is chosen, and if you chose one of files, you can't make this field empty, you just can choose one other file (and feature request is make possible multi files selection :) )

I'll make screen shot later, as soon as possible.

[Ilis]

Here it is my screen shot. Small box to the left of settings window is a desklet :)

[JessW]

@Ilis Thank you for the screenshot. It looks like a lot has changed in the recent Cinnamon releases. The good news is that I can reproduce the bug. I had an easier time getting Cinnamon 3.4, so I will work on it there, and hopefully that will fix the problem for you as well. Will let you know when I have something you can try, if you'd like.

Thanks so much for letting me know it's so broken!

[Ilis]

@JessW , thank you and hope you will keep me informed. When desklet will work, I make localization for it.

[JessW]

That would be fantastic, @Ilis !
Will keep you posted.

[JessW]

Hi @Ilis, I think I've fixed the problem, at least the desklet works correctly in Cinnamon 3.4 now. Since I haven't tested in with Cinnamon 3.2, would you be willing to test it out before I submit the pull request? My changes are here:
https://github.com/JessW/cinnamon-spices-desklets

If you put the contents of
cinnamon-spices-desklets/quoteOfTheDay@tinnu/files/
in
~/.local/share/cinnamon/desklets
you should be able to add it to your desktop.

When you configure it initially, the file should no longer say "None," and you should be able to change files and have it still work!

[Ilis]

@JessW , well, I put files from 3.2 folder of your repository to my local folder, desklet crashed with log message "metadata.js not found". I added that file from upper folder of repository and desklet started do the job.

When I change quotes file in settings, new quotes are shown.

Unfortunately, background is not transparent:

[Ilis]

I'm very sorry, background is not transparent when settings window is opened. Elsewhere it is transparent.

So, only metadata.js needed...

[JessW]

That's great! I was puzzled why it wouldn't be transparent. I don't see that in Cinnamon 3.4, but I guess it's kind of a nice feature to show what is being configured.

My understanding is that when the desklet is installed in the regular way, everything in
cinnamon-spices-desklets/quoteOfTheDay@tinnu/files/quoteOfTheDay@tinnu/
will be included, even if you are running Cinnamon 3.2+ If you check out
http://developer.linuxmint.com/reference/git/cinnamon-tutorials/xlet-versioning.html
it recommends putting metadata.json in that top level directory. But you are right, the desklet won't work without it!

I appreciate your help, @Ilis!

[Ilis]

It doesn't work after last update. Glass log has no errors.

[JessW]

Hm, does ~/.xsession-errors have any related errors, and do you happen to know what was updated? Is there just no quote displayed? I'm ​bummed to hear it's stopped working. It might be a few days, but I will see if I have updates on my Cinnamon 3.4 system to see if it stops working there, too. Thank you for letting me know!

…

On Sat, May 20, 2017, 11:50 AM Илья Кругликов ***@***.***> wrote: It doesn't work after last update. Glass log has no errors. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#118 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADCuSPzSQRbs4zraHLu5DfFdMbvTSlG3ks5r7xnXgaJpZM4NVt-n> .

[Ilis]

Hi, @JessW !
It was work when installed from 3.2 folder of your repository. Now I updated it from Spices repository (using standard update button of Preferences → Applets). I think it will work for me if I update it from your repository again, but it will not work for other 3.2 Cinnamon users.

[Ilis]

Finally it works!

Thank you, @JessW !

[JessW]

I'm glad to hear it! Thank you for bringing it to my attention, @Ilis :) Can you close the issue too, when you get a chance?

[JosephMcc]

Done :)

[JessW]

Thank you!