Giter Site home page Giter Site logo

Comments (8)

slgobinath avatar slgobinath commented on July 21, 2024 1

Thanks for your solution @jaszhix.
Considering the effort to maintain multiple versions, I prefer to let this desklet incompatible with Cinnamon 3.0.7.
In addition, I will provide a manual installation guide explaining how to clone and use an older version.

from cinnamon-spices-desklets.

NikoKrause avatar NikoKrause commented on July 21, 2024

@slgobinath

from cinnamon-spices-desklets.

slgobinath avatar slgobinath commented on July 21, 2024

Hi,
I am unable to produce this problem in my Linux Mint 18.3 with Cinnamon 3.6.7.
I will try this with your version in VM and let you know.

from cinnamon-spices-desklets.

slgobinath avatar slgobinath commented on July 21, 2024

@NikoKrause I have faced following problems in Cinnamon 3.0.7:

  1. Functions must be defined like this:
test: function() {

}

However, this format was marked as bad practice in last PR check.
2. Default settings values were not initialized. After fixing the above problem, I got this.bgcolor undefined in https://github.com/linuxmint/cinnamon-spices-desklets/blob/master/googleCalendar%40javahelps.com/files/googleCalendar%40javahelps.com/desklet.js#L210

Were there any breaking API changes after Cinnamon 3.0.7?

from cinnamon-spices-desklets.

NikoKrause avatar NikoKrause commented on July 21, 2024

Asking expert here: @jaszhix

from cinnamon-spices-desklets.

jaszhix avatar jaszhix commented on July 21, 2024

Which PR did the linter mark it as bad practice? The eslint configuration might still need some adjusting. I'm not sure what could be causing the undefined typeerror. I know in Cinnamon 3.2 a new API was introduced for the settings binding API, not sure if there would be behavior differences with the old API.

from cinnamon-spices-desklets.

slgobinath avatar slgobinath commented on July 21, 2024

Hi,
Please check #259 for Expected method shorthand. (object-shorthand) style warning.

from cinnamon-spices-desklets.

jaszhix avatar jaszhix commented on July 21, 2024

Cinnamon 3.0.7 is getting a bit old, you could try find a commit that you know works with it, and 'fork' that into a 3.0.7 directory, in files/UUID/, like this for example. Then move the latest version into a 3.6 directory (or whatever oldest version still works with the desklet). Then add a cinnamon-version property with an array of version strings in metadata.json. Or just add that to metadata.json without forking a 3.0.7 compatible version including the versions that still work in the list, and they should be alerted that the desklet is incompatible with Cinnamon 3.0.7.

from cinnamon-spices-desklets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.