simple-system-monitor@ariel andneed to be updated to support new NM library

[linuxmint]

simple-system-monitor@ariel and [email protected] need to be updated to support new NM library

[coderforlife]

Due to messed up formatting initially I am unsure if the mention of @arielandrade went through so repeating it.

[arielandrade]

Hello Jeffrey, I'm sorry but I can't mantain the desklet right now, I'll donate it so somebody else might fix it.

…

On Sat, Mar 3, 2018 at 6:15 PM, Jeffrey Bush ***@***.***> wrote: Due to messed up formatting initially I am unsure if the mention of @arielandrade <https://github.com/arielandrade> went through so repeating it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#279 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANpL4sbprIoUhSNlf6zwy_MIvMcsYd8tks5tawgOgaJpZM4SbFZ_> .

[pdcurtis]

I fixed the same issue in the matching applet [email protected] to the issue here in [email protected] - see linuxmint/cinnamon-spices-applets@33b76b8

I can have a look at system-monitor@ariel if nobody else shows an interest but it may be a while before I can allocate time and it probably needs to be fixed for Cinnamon 3.8

[pdcurtis]

I have found the time and hopefully fixed this issue for [email protected] and also a few anomalies I found during testing it.

I could only do partial testing on a LiveUSB of Fedora 27 so any feedback from users would be useful

[spantaleev]

I've recently started experiencing this same problem on Archlinux.

[pdcurtis]

@spantaleev Which applet/desklet is causing the problem and what version of cinnamon are you using?

[email protected] should have been fixed and I have just had a new version merged which will work better with cinnamon 4.0

@jaszhix has also recently pushed a fix for simple-system-monitor for 3.8 see #327

[spantaleev]

@pdcurtis, I'm on 4.0.3 and I'm affected by linuxmint/cinnamon#8050, which rejects loading simple-system-monitor@ariel.

[pdcurtis]

I will have a quick look to see if the fix @jaszhix has created for these xlets can easily be applied. He will probably want to comment as he has already been working on it and I am busy today.

[pdcurtis]

@spantaleev I have had a quick look and at https://github.com/pdcurtis/cinnamon-spices-desklets/tree/simple-system-monitor-1.0.0/simple-system-monitor%40ariel you will find a modified version which might work for you. It includes

• Changes for Cinnamon 4.0 and higher to avoid segfaults when old Network Manager Library is no longer available by using a multiversion with a 4.0 folder in which I have:
  • Commented out all references to NetworkManager
  • Replaced calls to NetworkManager with equivalent calls to NM
  • Changed logError messages to not reference NetworkManager

I hope you may be prepared to test it as I currently have no way to test under Cinnamon 4.0.x

If it looks promising I will generate a PR

@jaszhix for your information only - if this works it completes the xlets affected by linuxmint/cinnamon#8050 apart from '[email protected]' which seems to have disapeared

[jaszhix]

@pdcurtis Tested it real quick

Cjs-Message: 05:39:17.154: JS LOG: [LookingGlass/error]
[simple-system-monitor@ariel]: assignment to undeclared variable NMClient_new
[simple-system-monitor@ariel]: Error importing desklet.js from simple-system-monitor@ariel
Cjs-Message: 05:39:17.154: JS LOG: [LookingGlass/trace]
<----------------
anonymous@/home/jason/.local/share/cinnamon/desklets/simple-system-monitor@ariel/4.0/desklet.js:13:1
createExports@/usr/share/cinnamon/js/misc/fileUtils.js:210:31
requireModule/</<@/usr/share/cinnamon/js/misc/fileUtils.js:288:25
---------------->

[email protected] had a lot of python 2 code that was broken that required a lot of work on top of a python 3 port, so I removed it. Its in git history and tagged as applet removal though, so can always be revived if someone's interested.

[pdcurtis]

@jaszhix Thanks,
Deleted the let NMClient_new; without noticing - fixed and pushed.

[pdcurtis]

I have tested my latest updates to simple-system-monitor under Cinnamon 4.03 on a LiveUSB pushed it and created a PR

[spantaleev]

Thanks @pdcurtis!

Sorry I haven't been able to find time to test this and help you out.. Been on the go lately..