2.6.0 fails to build when meson build type is plain: unknown type name 'DebugFlags'

[bobby285271]

2.6.0 fails to build when meson build type is plain: unknown type name 'DebugFlags'

[mtwebster]

I gave --buildtype=debugoptimized a try and the build succeed, looking at this I wonder if we are encouraged to package in this way:

As the guy fielding bug reports, I'd recommend it - I think that was the point of 'debugoptimized' also. There's a little bit of detail under rule 4 here.

[z1atk0]

Same here, configured with meson setup -D buildtype=release. The following patch fixes this problem (github won't let me add this as an attachment - "We don't support that file type" 🤷‍♂️).

diff -pru xapp-2.6.0-orig/libxapp/xapp-debug.c xapp-2.6.0/libxapp/xapp-debug.c
--- xapp-2.6.0-orig/libxapp/xapp-debug.c	2023-06-01 11:17:06.000000000 +0200
+++ xapp-2.6.0/libxapp/xapp-debug.c	2023-06-02 21:06:04.203763532 +0200
@@ -22,6 +22,8 @@
  * Copied from nemo
  */
 
+#ifdef ENABLE_DEBUG
+
 #include <stdarg.h>
 
 #include <glib.h>
@@ -127,3 +129,4 @@ xapp_debug_valist (DebugFlags flag,
   }
 }
 
+#endif

[mtwebster]

Fixed by 2015b64