Home page no tiles shown for finished projects, just empty space

[maxliqd]

Home page no tiles shown for finished projects, just empty space

[philli-m]

NOTES:
We limit the list of projects permitted for the storefront to just running ones:

a4-meinberlin/meinberlin/apps/cms/models/storefronts.py

Line 20 in 01b1725

def project_choice_limit():

As long as we don't edit the store front items after a selected project is finished it will display the project, this is the intended behavior.
If we edit the storefront after one of the selected projects has finished the projects update and there is now an empty item in the random_items list as a finished project does not fit the 'project_choice_limit' anymore
I think this is whats happening anyway.

@Rineee i mistook this for a frontend problem and am now not sure on the best approach here, I don't know a way to make the storefront snippet know to keep all existing random_items unless formfield is deleted of changed. Unfortunatly the formfield does unset it's self when the project ends but it doesn't register as an empty field, can be seen here in third one down https://meinberlin-dev.liqd.net/admin/snippets/meinberlin_cms/storefront/edit/1/#tab-project_tiles
any pointers would be appreciated but I can also take another hit at it next week as there's a bunch of story related issues before release

[Rineee]

@philli-m @maxliqd So the desired behaviour would be that finished projects are still shown, right? You can only not add an already finished project to the storefront, but if it finishes later, it should still show?

[maxliqd]

@Rineee Yes, finished projects shall still appear in the storefront if they were added before as a running project. But you cannot add an already finished project, because otherwise the list would be way too long. That's how I understood @philli-m

[philli-m]

@Rineee also to note in case it wasn't clear, finished projects are still shown as finished tiles until the list is edited in wagtail then they become blank entries