[macos/clang] Tests are failing

[iamazeem]

[macos/clang] Tests are failing

[liquidaty]

These failures do not happen on native OSX (intel or M-1). could this be a problem with the runner environment?

[iamazeem]

I'm not sure whether it's a runner problem or not.
I've tested both macOS-10.15 and macos-11. Tests fail on both.

Could you share the native OSX and clang versions you're testing it with?

[iamazeem]

I've generated a build without tests.
zsv version is working fine here.

Please download and test macos/clang build from here and test it on your side.
CI run without tests: https://github.com/liquidaty/zsv/runs/6692905229

[iamazeem]

@liquidaty: I spent some time to figure out why the tests were failing for macosx/gcc, macosx/clang, and freebsd/gcc.
Added some debug logs and commands to verify whether the test binaries are valid or not.

For example:

test-echo : ${BUILD_DIR}/bin/zsv_echo${EXE}
	@${TEST_NAME}
	@echo $<
	@file $<
	@ls -Gghl $<
	$< --help
	@${PREFIX} $< ${TEST_DATA_DIR}/loans_1.csv ${REDIRECT} /tmp/[email protected]
	@${CMP} /tmp/[email protected] expected/[email protected] && ${TEST_PASS} || ${TEST_FAIL}

and, the output:

test-echo: 
/Users/runner/work/zsv/zsv/build/Darwin/rel/gcc-11/bin/zsv_echo
/Users/runner/work/zsv/zsv/build/Darwin/rel/gcc-11/bin/zsv_echo: Mach-O 64-bit executable x86_64
-rwxr-xr-x  1 staff    67K Jun 15 12:30 /Users/runner/work/zsv/zsv/build/Darwin/rel/gcc-11/bin/zsv_echo
/Users/runner/work/zsv/zsv/build/Darwin/rel/gcc-11/bin/zsv_echo --help
Usage: csv_echo [-b, --with-bom] [filename]
  Reads CSV input and prints CSV output with BOM prefix
Options:
    -b, --with-bom: print byte-order mark
/bin/sh: line 1:  8759 Illegal instruction: 4  /Users/runner/work/zsv/zsv/build/Darwin/rel/gcc-11/bin/zsv_echo /Users/runner/work/zsv/zsv/data/loans_1.csv > /tmp/test-echo.out
make[2]: *** [test-echo] Error 132
make[1]: *** [test-echo] Error 2
make: *** [test] Error 2

The above logs show that the binary itself is working fine.
Only when it's given the input file is when it starts crashing.

You might want to run generate all the test binaries and analyze those under gdb and/or valgrind to figure out the exact reason of the crash.