Giter Site home page Giter Site logo

Comments (8)

UrekD avatar UrekD commented on May 16, 2024 2

Playing around with inspect element I think I found the issue, it seems to be the font it gets from css class html .jsoneditor * instead of the correct one from .ace-jsoneditor *, deactivating the font from .jsoneditor * fixed it, see below for refference.

image

from dashy.

UrekD avatar UrekD commented on May 16, 2024 1

Should still be relevant. Thanks for the hard work :)

from dashy.

Lissy93 avatar Lissy93 commented on May 16, 2024 1

Just a quick update - I haven't forgotten about this, but it's proving not so simple to diagnose.

I believe the issue is with the JSON editor plugin that I'm using rather than Dashy, and I think it has something to do with varying character widths. Similar issues were raised in the past on the plugin, but no clear solutions

For me, I've only been able to re-create the issue once, and I can't remember what I did to get there. Using Brave 1.30, or Firefox 93 on Linux, with a small-ish config file, I don't see the bug. Will keep this issue open, but if anyone has any ideas on a fix, or any more info, that would be really helpful :)

from dashy.

Inrego avatar Inrego commented on May 16, 2024

I'm not sure if my issue is related. But for me, it's way worse. The caret is showing a few characters to the left of where it actually is. It worsens the longer the line is.

Example:
image
This is the last position of this line. Tapping right arrow on my keyboard will move the caret to next line. Typing anything will add characters after that last comma.

I'm using Microsoft Edge. and have confirmed same issue on Chrome (both are Chromium browsers, so it makes sense)

from dashy.

UrekD avatar UrekD commented on May 16, 2024

@Inrego yeah it's the same issue. It's as bad as you describe as you suggest it might be due to longer lines as in the 2nd gif at the end you can see when I double click I believe "Supermicro" you see it's offset by quite a few characters and editing it is as you described.

from dashy.

Lissy93 avatar Lissy93 commented on May 16, 2024

This is indeed an issue, although I've not been able to fix it so far. I will leave this issue open, and if either of you feel like submitting a PR for it, that would be awesome :)

from dashy.

liss-bot avatar liss-bot commented on May 16, 2024

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

from dashy.

Lissy93 avatar Lissy93 commented on May 16, 2024

Thank you so much @UrekD for fixing this, nice work! 🙌🥳
PR #315 is now merged and available on DockerHub and changes visible in the dev environment: dev.dashy.to

There's also a new config editor, merged in #298, and released in V 1.9.0, which doesn't require you to write JSON anymore, and may be helpful to some of you.

from dashy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.