Comments (5)
Actually, this sounds like something which should be implemented by default.
If basic auth is enabled, and the user is not logged in, they shouldn't be able to write any changes.
Thoughts?
from dashy.
maybe an option disableSettings to globally stop non-admin to edit and basically view only
Thanks @rxunique - Done!
I figured, if you've setup basic auth, and have guest access enabled- you wouldn't want guests to be able to edit configuration (otherwise there's not much point to the auth, beyond roles).
So instead of adding an extra option to disable edits from guests, it's now (since V 3.0.1) disabled by default. And so logging in is required to make changes, if auth is enabled.
If you need anything else modifying around this, let me know below, and I'll reopen.
from dashy.
If you're enjoying Dashy, consider dropping us a ⭐
🤖 I'm a bot, and this message was automated
from dashy.
+1
from dashy.
should be implemented by default
Do you mean there is already implementation? Or thinking its a good idea to be default?
If basic auth is enabled, and the user is not logged in
In my mind, I was hoping add an option to appConfig.hideComponents
. currently hideSettings
only collapsed the setting
maybe an option disableSettings
to globally stop non-admin to edit and basically view only
from dashy.
Related Issues (20)
- [BUG] Startup on 3.1.0 consumes too much cpu HOT 21
- [BUG] Unauthorized user can access /conf.yml HOT 1
- [BUG] Updated the container and my customizations are missing HOT 8
- [BUG] Favicon not loading on page load HOT 5
- [Feature_Request] add new type of Window
- [BUG] widget gets placed in the wrong spot in the dashboard HOT 3
- [BUG] Glances Issue HOT 9
- Keycloak and user type HOT 1
- own config not loaded after upgrade to 3.1 <title> HOT 4
- [QUESTION] Issue running docker command HOT 3
- [FEATURE_REQUEST] <Widgets for Zabbix>
- [BUG] Minimal view as starting view not using correct theme HOT 6
- [BUG] yarn.lock update for heroku (on Netlify)
- [QUESTION] Cookies or Session states cleared/reset when link clicked? HOT 11
- [BUG] Glances Network Traffic Error HOT 2
- error 404 all of a sudden HOT 35
- Custom color settings revert to theme default when you click Cancel HOT 1
- font-awesome icons only work if there's no dash in the icon name HOT 3
- [BUG] Keycloak authentication breaks Dashy HOT 1
- SEVERE bug in Dashy - looping reinstall after adding basic auth to conf.yml HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dashy.