Comments (7)
I believe this should be possible by modifying the build command, to include the --no-clean
flag [docs]
Lines 24 to 25 in eea193a
- RUN yarn build --mode production
+ RUN yarn build --mode production --no-clean
I'll test that out this evening, and see if I can get a PR for you :)
from dashy.
Ah yes, you're right, it should go in the run stage, and not the build stage - so the package.json under build-and-start
command would work
from dashy.
Yeah, it should. I'll do it when I get a moment, it's not merged yet, so it's chill
from dashy.
I will close this issue since I have a temporary workaround for now.
from dashy.
Hi @Lissy93 , thank you for the quick reply and taking this on.
I saw the commit, but please correct me if I am wrong (I know nothing of nodejs/yarn/etc), but isn't the issue that docker command is:
Thank build-and-start
calls build
:
https://github.com/Lissy93/dashy/blob/master/package.json#L14
and that build
is missing the flag --no-clean
?
https://github.com/Lissy93/dashy/blob/master/package.json#L10
Even if you change the dockerfile the build call above will (try to) remove the directory at runtime?
from dashy.
Basically I tried this change locally (adding a couple of yarn scripts in the package.json):
And if they are there, in k8s I can override the command and call the no-clean option:
command:
- yarn
- build-no-clean-and-start
I am not doing the PR because I understand the change is horrible, and I don't expect to pollute the repo with every single user usecase ^^ But maybe the example can help finding a cleaner solution to allow the no-clean option?
from dashy.
@Lissy93
Shouldn't the commit with the no-clean flag be reverted then?
from dashy.
Related Issues (20)
- [BUG] Favicon not loading on page load HOT 5
- [Feature_Request] add new type of Window
- [BUG] widget gets placed in the wrong spot in the dashboard HOT 3
- [BUG] Glances Issue HOT 9
- Keycloak and user type HOT 1
- own config not loaded after upgrade to 3.1 <title> HOT 4
- [QUESTION] Issue running docker command HOT 3
- [FEATURE_REQUEST] <Widgets for Zabbix>
- [BUG] Minimal view as starting view not using correct theme HOT 6
- [BUG] yarn.lock update for heroku (on Netlify)
- [QUESTION] Cookies or Session states cleared/reset when link clicked? HOT 11
- [BUG] Glances Network Traffic Error HOT 2
- error 404 all of a sudden HOT 35
- Custom color settings revert to theme default when you click Cancel HOT 1
- font-awesome icons only work if there's no dash in the icon name HOT 3
- [BUG] Keycloak authentication breaks Dashy HOT 1
- SEVERE bug in Dashy - looping reinstall after adding basic auth to conf.yml HOT 5
- [SHOWCASE] <A Simple Dash> HOT 2
- [BUG] My Dashy Docker container keeps looping and not starting HOT 10
- [FEATURE_REQUEST] Update to Vue3 (Vue2 is EOL)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dashy.