Giter Site home page Giter Site logo

Fix "vanilla cmake" build system about raja HOT 14 CLOSED

llnl avatar llnl commented on May 28, 2024
Fix "vanilla cmake" build system

from raja.

Comments (14)

DavidPoliakoff avatar DavidPoliakoff commented on May 28, 2024

Think @davidbeckingsale is out, I'll give it a look. See #23 for why we initially wanted to move away from host-configs, it died in a confusing way for users not on an LC system. Spack is still of interest. I'm responding to your email now, but that's the short version

from raja.

davidbeckingsale avatar davidbeckingsale commented on May 28, 2024

I have a response on the way, and am currently building/running with both Clang and GCC on Vulcan.

from raja.

DavidPoliakoff avatar DavidPoliakoff commented on May 28, 2024

Hey, is this still an open problem? If it is, should I be doing things to solve it?

from raja.

davidbeckingsale avatar davidbeckingsale commented on May 28, 2024

Rich and I have this under control. You are welcome to give the 'features/both-builds' branch a try if you are interested in seeing the changes.

from raja.

rhornung67 avatar rhornung67 commented on May 28, 2024

@DavidPoliakoff and @davidbeckingsale I just pushed a minor change to quiet a clang compiler warning. I think we're good for now (it will satisfy most folks, I believe) and the branch can be merged into develop. If you agree, we should do this soon since I updated the configuration and build section of the user docs and pushed those changes. Can one/both of you give them a quick read and let me know if you want me to change anything or if I missed something? Thanks.

from raja.

davidbeckingsale avatar davidbeckingsale commented on May 28, 2024

Build docs look good to me.

Cheers,
--David


David Beckingsale, [email protected], people.llnl.gov/david http://people.llnl.gov/david
Center for Applied Scientific Computing @ Lawrence Livermore National Laboratory

On Jun 16, 2016, at 11:58 AM, rhornung67 [email protected] wrote:

@DavidPoliakoff https://github.com/DavidPoliakoff and @davidbeckingsale https://github.com/davidbeckingsale I just pushed a minor change to quiet a clang compiler warning. I think we're good for now (it will satisfy most folks, I believe) and the branch can be merged into develop. If you agree, we should do this soon since I updated the configuration and build section of the user docs and pushed those changes. Can one/both of you give them a quick read and let me know if you want me to change anything or if I missed something? Thanks.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #52 (comment), or mute the thread https://github.com/notifications/unsubscribe/AAUak0vU8SRdBg3-fc-DDjPxUvs9n3-Yks5qMZzKgaJpZM4IzYY0.

from raja.

rhornung67 avatar rhornung67 commented on May 28, 2024

Thanks. Merge away!

From: David Beckingsale <[email protected]mailto:[email protected]>
Reply-To: LLNL/RAJA <[email protected]mailto:[email protected]>
Date: Thursday, June 16, 2016 at 12:00 PM
To: LLNL/RAJA <[email protected]mailto:[email protected]>
Cc: Rich Hornung <[email protected]mailto:[email protected]>, Mention <[email protected]mailto:[email protected]>
Subject: Re: [LLNL/RAJA] Fix "vanilla cmake" build system (#52)

Build docs look good to me.

Cheers,
--David


David Beckingsale, [email protected]:[email protected], people.llnl.gov/david http://people.llnl.gov/david
Center for Applied Scientific Computing @ Lawrence Livermore National Laboratory

On Jun 16, 2016, at 11:58 AM, rhornung67 <[email protected]mailto:[email protected]> wrote:

@DavidPoliakoff https://github.com/DavidPoliakoff and @davidbeckingsale https://github.com/davidbeckingsale I just pushed a minor change to quiet a clang compiler warning. I think we're good for now (it will satisfy most folks, I believe) and the branch can be merged into develop. If you agree, we should do this soon since I updated the configuration and build section of the user docs and pushed those changes. Can one/both of you give them a quick read and let me know if you want me to change anything or if I missed something? Thanks.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #52 (comment), or mute the thread https://github.com/notifications/unsubscribe/AAUak0vU8SRdBg3-fc-DDjPxUvs9n3-Yks5qMZzKgaJpZM4IzYY0.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/52#issuecomment-226581192, or mute the threadhttps://github.com/notifications/unsubscribe/AMNRnO4dTrOxdSQuyQJbeazB9O4pFK9Cks5qMZ03gaJpZM4IzYY0.

from raja.

davidbeckingsale avatar davidbeckingsale commented on May 28, 2024

Will merge after lunch, couple of conflicts to fix.

Cheers,
--David


David Beckingsale, [email protected], people.llnl.gov/david http://people.llnl.gov/david
Center for Applied Scientific Computing @ Lawrence Livermore National Laboratory

On Jun 16, 2016, at 12:01 PM, rhornung67 [email protected] wrote:

Thanks. Merge away!

From: David Beckingsale <[email protected]mailto:[email protected]>
Reply-To: LLNL/RAJA <[email protected]mailto:[email protected]>
Date: Thursday, June 16, 2016 at 12:00 PM
To: LLNL/RAJA <[email protected]mailto:[email protected]>
Cc: Rich Hornung <[email protected]mailto:[email protected]>, Mention <[email protected]mailto:[email protected]>
Subject: Re: [LLNL/RAJA] Fix "vanilla cmake" build system (#52)

Build docs look good to me.

Cheers,
--David


David Beckingsale, [email protected]:[email protected], people.llnl.gov/david http://people.llnl.gov/david
Center for Applied Scientific Computing @ Lawrence Livermore National Laboratory

On Jun 16, 2016, at 11:58 AM, rhornung67 <[email protected]mailto:[email protected]> wrote:

@DavidPoliakoff https://github.com/DavidPoliakoff and @davidbeckingsale https://github.com/davidbeckingsale I just pushed a minor change to quiet a clang compiler warning. I think we're good for now (it will satisfy most folks, I believe) and the branch can be merged into develop. If you agree, we should do this soon since I updated the configuration and build section of the user docs and pushed those changes. Can one/both of you give them a quick read and let me know if you want me to change anything or if I missed something? Thanks.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #52 (comment), or mute the thread https://github.com/notifications/unsubscribe/AAUak0vU8SRdBg3-fc-DDjPxUvs9n3-Yks5qMZzKgaJpZM4IzYY0.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/52#issuecomment-226581192, or mute the threadhttps://github.com/notifications/unsubscribe/AMNRnO4dTrOxdSQuyQJbeazB9O4pFK9Cks5qMZ03gaJpZM4IzYY0.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #52 (comment), or mute the thread https://github.com/notifications/unsubscribe/AAUak_5jR_UFfCL1tn_-1pn9DDgdCTtpks5qMZ2PgaJpZM4IzYY0.

from raja.

rhornung67 avatar rhornung67 commented on May 28, 2024

We’ve got an issue with icpc 16.0.109 on chaos. CMake is reporting an error and I don’t understand what the output log file is telling me. Can you look at that? Thanks.

From: David Beckingsale <[email protected]mailto:[email protected]>
Reply-To: LLNL/RAJA <[email protected]mailto:[email protected]>
Date: Thursday, June 16, 2016 at 12:07 PM
To: LLNL/RAJA <[email protected]mailto:[email protected]>
Cc: Rich Hornung <[email protected]mailto:[email protected]>, Mention <[email protected]mailto:[email protected]>
Subject: Re: [LLNL/RAJA] Fix "vanilla cmake" build system (#52)

Will merge after lunch, couple of conflicts to fix.

Cheers,
--David


David Beckingsale, [email protected]:[email protected], people.llnl.gov/david http://people.llnl.gov/david
Center for Applied Scientific Computing @ Lawrence Livermore National Laboratory

On Jun 16, 2016, at 12:01 PM, rhornung67 <[email protected]mailto:[email protected]> wrote:

Thanks. Merge away!

From: David Beckingsale <[email protected]mailto:[email protected]mailto:[email protected]>
Reply-To: LLNL/RAJA <[email protected]mailto:[email protected]mailto:[email protected]>
Date: Thursday, June 16, 2016 at 12:00 PM
To: LLNL/RAJA <[email protected]mailto:[email protected]mailto:[email protected]>
Cc: Rich Hornung <[email protected]mailto:[email protected]mailto:[email protected]>, Mention <[email protected]mailto:[email protected]mailto:[email protected]>
Subject: Re: [LLNL/RAJA] Fix "vanilla cmake" build system (#52)

Build docs look good to me.

Cheers,
--David


David Beckingsale, [email protected]:[email protected]:[email protected], people.llnl.gov/david http://people.llnl.gov/david
Center for Applied Scientific Computing @ Lawrence Livermore National Laboratory

On Jun 16, 2016, at 11:58 AM, rhornung67 <[email protected]mailto:[email protected]mailto:[email protected]> wrote:

@DavidPoliakoff https://github.com/DavidPoliakoff and @davidbeckingsale https://github.com/davidbeckingsale I just pushed a minor change to quiet a clang compiler warning. I think we're good for now (it will satisfy most folks, I believe) and the branch can be merged into develop. If you agree, we should do this soon since I updated the configuration and build section of the user docs and pushed those changes. Can one/both of you give them a quick read and let me know if you want me to change anything or if I missed something? Thanks.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #52 (comment), or mute the thread https://github.com/notifications/unsubscribe/AAUak0vU8SRdBg3-fc-DDjPxUvs9n3-Yks5qMZzKgaJpZM4IzYY0.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/52#issuecomment-226581192, or mute the threadhttps://github.com/notifications/unsubscribe/AMNRnO4dTrOxdSQuyQJbeazB9O4pFK9Cks5qMZ03gaJpZM4IzYY0.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #52 (comment), or mute the thread https://github.com/notifications/unsubscribe/AAUak_5jR_UFfCL1tn_-1pn9DDgdCTtpks5qMZ2PgaJpZM4IzYY0.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/52#issuecomment-226583120, or mute the threadhttps://github.com/notifications/unsubscribe/AMNRnGsKuAle-HfhuD-If7zvcR-cZZePks5qMZ7mgaJpZM4IzYY0.

from raja.

rhornung67 avatar rhornung67 commented on May 28, 2024

@davidbeckingsale I've committed a coupld of fixes for icpc on chaos. However, We're getting some error out of CMake about not knowing how to set the C++11 compiler flags. The code builds and runs

from raja.

davidbeckingsale avatar davidbeckingsale commented on May 28, 2024

Pinging @trws - what's the best way to deal with some compilers (Intel) not being handled by CMake's CXX_STANDARD stuff?

from raja.

trws avatar trws commented on May 28, 2024

Best? Use a newer version of cmake. The newest does support ICC for that stuff.

Realistic? Since we care about ICC, check the CMAKE_COMPILER_ID, and if it's ICC and the version is below add the known flag. We'll probably want to do the same thing for XL and PGI.

Also, why closed?

from raja.

davidbeckingsale avatar davidbeckingsale commented on May 28, 2024

from raja.

trws avatar trws commented on May 28, 2024

Note: it is apparently possible to install icc/icpc on travis, we should talk to the Intel license folks about getting that done. Also the BGQ cross-compiler if we can find a way.

from raja.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.