URL parameters in source connector don't seem to work

[llofberg]

URL parameters in source connector don't seem to work

[amilbourne]

My suggested solution is to change the config parameters as follows:

Split the data (payload) parameter into URL Parameters and Body Content as 2 separate config params.
The URL Parameters would be a list of strings, each being of the form 'key=value'. This would allow the part after the first equals to be URL Encoded.

So the old config might have been (although I don't think this would have worked correctly):

"rest.source.method": "GET",
"rest.source.url": "http://example.com/rest-endpoint",
"rest.source.data":"param1=val1&param2=1+2"

So the new config might look like:

"rest.source.method": "POST",
"rest.source.url": "http://example.com/rest-endpoint",
"rest.source.payload.body":"Couldn't be done under old code"
"rest.source.payload.params": [ "param1=val1", "param2=1+2" ]

Obviously this would be a breaking change.

What do you think? Can you think of a better solution or a reason why it isn't an issue?

[amilbourne]

I am happy to fix this (or be wrong about the problem) - I an just trying to get feedback on the best way to do it.

[amilbourne]

My suggested syntax above doesn't seem to work. I was a bit confused and was trying to mix properties and JSON syntax :-(

A revised version (which isn't as elegant) could be:

"rest.source.method": "POST",
"rest.source.url": "http://example.com/rest-endpoint",
"rest.source.body":"Couldn't be done under old code"
"rest.source.param.names": "param1, param2"
"rest.source.param.param1.value": "val1"
"rest.source.param.param2.value": "1+2"

[amilbourne]

Thanks for merging this.
This issue should hopefully be resolved now.