Failed verification of struct attribute with pointer-to-array initializer

[yugr]

Failed verification of struct attribute with pointer-to-array initializer

[bcardosolopes]

@sitio-couto could this be due to recent changes in struct or just something we haven't implemented?

[sitio-couto]

@bcardosolopes seems to be a corner that we still need to handle.

The issue warned is a type mismatch because the a[0] access does not dereferencing the type. In other words, the [0] access of a is not converting the !cir.array<!cir.int<s, 32> x 10> type to just !cir.int<s, 32>.

It seems that after the indices are applied on the GlobalViewAttr the result type was not updated:

clangir/clang/lib/CIR/CodeGen/CIRGenExprConst.cpp

Lines 1080 to 1081 in 62b44c8

	return mlir::cir::GlobalViewAttr::get(
	GV.getType(), GV.getSymbol(), getOffset(GV.getType()));

And there is a guard against zero offsets (which can't be ignored on CIR due to type checking):

clangir/clang/lib/CIR/CodeGen/CIRGenExprConst.cpp

Lines 1073 to 1074 in 62b44c8

	if (!hasNonZeroOffset())
	return C;

Seems like a simple patch. I'll try to fix it.

[yugr]

It seems that after the indices are applied on the GlobalViewAttr the result type was not updated:

My mistake, thanks for fixing.