Error when running example scripts

[llvm]

Error when running example scripts

[hunbssfy]

Right! I'll keep an eye on the progress :)

[cathyzhyi]

Hey Maxi, you didn't miss any steps.
For the first error, the short answer is that aten.cos.out is not supported yet. In order to support this, we need to update torch_ods_gen.py and run build_tools/update_torch_ods.sh to generate the ods and lower this op in TorchToLinalg.
For the second error, I can reproduce on my end but I am not sure what's the problem either. @silvasean is more experienced with this project but he's on vacation at the moment. Sry!

[hunbssfy]

@cathyzhyi
Hello Cathy,
Thanks for the reply! Is there any code submission similar to this kind of operator support that I can take a look at? Just want to get to know the whole lowering pass :)

[cathyzhyi]

Hey Maxi, I can't find a good example of one single PR containing all the supports for one operator but you could use aten::relu as an example. Running build_tools/update_torch_ods.sh generates a file called JITOperatorRegistryDump.txt which contains all the operators with schema. You can find aten::relu and aten::cos.out in there. After that, you could try to follow example of aten::relu and AtenReluOp in the codebase. Please let me know if you have any issues.

[hunbssfy]

@cathyzhyi
Hello Cathy,
I have been reading code and running some test...

I got some questions wanna ask:

1. What is your current status and plan for supporting the common deep learning models? For example, Resnet 50. I see that there is a Resnet18 test case (torchscript e2e test) but it fails during the lowering phase (I am using IREE backend). And I see that silva is working on supporting the Resnet model here: #212
2. Are you considering merging into the IREE project as one of its frontends in the future? It would be great because currently IREE already has Tensorflow frontend.

Thanks!

[stellaraccident]

Sean and Cathy can comment on their roadmap for supporting more models -- it is being actively worked on.

Regarding (2) - I am working this month on the python deployment machinery so that both npcomp and iree can be easily installed and the intent is that this will allow npcomp to use iree as a backend directly by regular users. It may take some iterations to get right as these are complicated dependencies but I expect this to start to become usable for folks within the next few months. IREE is hoping that the npcomp project can use it out of the box as an out of tree backend without the iree team needing to maintain an in tree PyTorch frontend itself.

[hunbssfy]

Great to know that, looking forward to it becomes more usable!

[cathyzhyi]

What is your current status and plan for supporting the common deep learning models? For example, Resnet 50. I see that there is a Resnet18 test case (torchscript e2e test) but it fails during the lowering phase (I am using IREE backend). And I see that silva is working on supporting the Resnet model here: Progress on lowering ResNet #212

yea, we are working on making Resnet18 work which is one of the targets in the Q3 roadmap. Most of the recent PRs are relevant to this item.

[silvasean]

FWIW, the .out variants are likely best handled in ReduceOpVariants. They can all be systematically handled there.

[dan-garvey]

@hunbssfy btw resnet_18 to iree now works, just edit the frontends/pytorch/examples/ script and set iree as backend.

[hunbssfy]

@hunbssfy btw resnet_18 to iree now works, just edit the frontends/pytorch/examples/ script and set iree as backend.

Yeah, I did the same modification and it works :)