Error when building npcomp in docker

[llvm]

Error when building npcomp in docker

[hunbssfy]

@silvasean
Hi, I just tried the newest commit and both commands seem to go through. Although I am running a custom-built IREE and e2e test failed, I'll have a look at the tests myself, Thanks!

[silvasean]

The latest IREE has the fix for builtin.module. This is the current list I see locally (will update xfail sets soon)

PASS - "MmModule_basic"
PASS - "MmModule_chained"
PASS - "MmDagModule_basic"
PASS - "MmTanhModule_basic"
PASS - "AdaptiveAvgPool2dModule_basic"
PASS - "FlattenStaticModule_basic"
PASS - "FlattenRank0Module_basic"
XFAIL - "FlattenDynamicModule_basic"
XFAIL - "MaxPool2dModule_basic"
XPASS - "ResNet18Module_basic"
PASS - "Mlp1LayerModule_basic"
PASS - "Mlp2LayerModule_basic"
PASS - "Conv2dNoPaddingModule_basic"
FAIL - "Conv2dWithPaddingModule_basic"
XFAIL - "Conv2dWithPaddingDilationStrideModule_basic"
PASS - "BatchNorm1DModule_basic"
PASS - "BatchNorm2DModule_basic"
PASS - "BatchNorm3DModule_basic"
XFAIL - "QuantizedMLP_basic"
PASS - "ElementwiseUnaryModule_basic"
PASS - "ElementwiseBinaryModule_basic"
PASS - "ElementwiseTernaryModule_basic"
PASS - "ElementwiseAddModule_basic"
PASS - "ElementwiseUnsqueezeBroadcastModule_basic"
PASS - "ElementwiseFlattenBroadcastModule_basic"
PASS - "ElementwiseReluModule_basic"

[silvasean]

I just refreshed the instructions: a153cf4

Can you give them a try? If not, can you include the full logs with the errors?

[hunbssfy]

Hi @silvasean,

About the failed tests yesterday... I started a fresh docker and built npcomp, I installed iree (not my custom built one) via pip. But the tests still failed:

Maybe the newest commits caused this?

[cathyzhyi]

Currently IREE backend is failing because we bumped our LLVM version to pickup some fixes and changes from the upstream but IREE is still using the old LLVM. If you add -v you will see the failure is because builtin.module can't be recognized. The op is the result of recent MLIR refactoring and the older MLIR used by IREE is not aware of this op.

Other than the LLVM version issue, there might be some smaller issues which should be fixed shortly.

[cathyzhyi]

Ha, seems ResNet18Module_basic passed with IREE as well?

[silvasean]

yep :)

[hunbssfy]

@silvasean Do you know which patch in iree fix the builtin.module issue?

[stellaraccident]

It's an asm format change from upstream. It will have come in via an iree submodule bump. We don't track such unstable changes between releases.

[hunbssfy]

@stellaraccident Thanks, I'll just update upstream version directly.