PHP 8.2

[lm-commons]

PHP 8.2

[visto9259]

Hi everyone,

Let me take a look at the PR and make a release.

Sorry for the delay, we are only spending time on maintenance on our spare time...

[visto9259]

This will take a few iterations.
There are many deprecation notices when running the test suite on php 8.2 in addition to the one mentioned above.

[curzio-della-santa]

@curzio-della-santa did you test other sources how it works with PHP 8.2? any other issues?

Yes I did test, and I found no additional dynamic assignment in this library.

[curzio-della-santa]

Agree with lon9man

I've checked the code, the mentioned line sets a dynamic-property that does not seem to be used anywhere.

Since there is a public getter for Request, this line could be removed without causing problems to the vast majority of user.
If someone is relying on this property to exist (despite the poor programming), can change the code to use the getter instead.

Because depreaction notices are usually not shown in production environments, is it currently for me only an annoying problem in test environment.

[tomekszad]

@lon9man @curzio-della-santa did you manage to overcome this issue? If yes, how? Thank you for your inputs!

[curzio-della-santa]

@tomekszad I've now written the PR to delete this malicious line, hope the maintainers of the library approve it for next release.

As said above, is only a warning for a line that can be simply commented out or removed in development environment, where deprecation warning are normally returned in the output.

In my current situation I can simply comment out the line after composer install.

Can be done with following command on CLI:

sed -i '100 s/^/\/\//' vendor/lm-commons/lmc-user/src/Authentication/Adapter/AdapterChainEvent.php

(Warning, this script comments out line 100 regardless what's in it, use at own risk)

[tomekszad]

@curzio-della-santa thank you for your reply! We on the other hand, have simply forked the repo, and fixed it on our fork.

Cheers!

[lon9man]

@curzio-della-santa did you test other sources how it works with PHP 8.2? any other issues?