Giter Site home page Giter Site logo

Comments (16)

jdalton avatar jdalton commented on May 19, 2024

It looks CSS related but not sure what's causing it (there's plenty of places for it to buckle down on).

from lodash.com.

calvinf avatar calvinf commented on May 19, 2024

In glancing through the JS, it may be related to initializing React state
by parsing the DOM. The selectors could be more efficient, and some
debouncing may avoid it locking up. Not sure if that's root cause but
something to check.
On Thu, Sep 1, 2016 at 6:09 PM John-David Dalton [email protected]
wrote:

It looks CSS related but not sure what's causing it (there's plenty of
places for it to buckle down on).


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#45 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACdNX-CnTerfVUC2vy7m01bqgIWoVkWks5ql3dIgaJpZM4JzOtZ
.

from lodash.com.

jdalton avatar jdalton commented on May 19, 2024

If I remove all JS on the page it still locks up. If I remove the CSS the page loads w/o locking up.

from lodash.com.

jdalton avatar jdalton commented on May 19, 2024

If you come up with anything let me know.
For now it's just one of those things I hope gets better with time.

from lodash.com.

ivan-kolmychek avatar ivan-kolmychek commented on May 19, 2024

Just stumbled upon the same issue, disabling the CSS helps.

From quick "performance" run that I was able to do in Firefox, it spends a lot of time in styles.

from lodash.com.

ivan-kolmychek avatar ivan-kolmychek commented on May 19, 2024

Here is a screenshot of profile with just single page reload.

screenshot_20160906_190453

I had lodash docs page already opened with CSS enabled, I've started the performance recording and just reloaded the page.

from lodash.com.

jdalton avatar jdalton commented on May 19, 2024

\cc @bzbarsky

from lodash.com.

zackhall avatar zackhall commented on May 19, 2024

My initial thought was similar to @calvinf's: maybe initializing the react state by reading, parsing the DOM was locking it up and retriggering layouts.

However, it's heavy layout cycles of 40-80ms causing this that are triggered before the initial render from docs.js.

In screenshot below, initial evaluation of the javascript is the blue bar, and sub-details, on the right. The layouts are the purple blocks.

image

from lodash.com.

bzbarsky avatar bzbarsky commented on May 19, 2024

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1300939

from lodash.com.

bzbarsky avatar bzbarsky commented on May 19, 2024

And in particular, it's something about the combination of flex from main.css and something the fontawesome stylesheet is doing that causes the slowdown in Firefox. Not clear what yet.

from lodash.com.

jdalton avatar jdalton commented on May 19, 2024

@bzbarsky Thank you so much for digging into this!

from lodash.com.

bzbarsky avatar bzbarsky commented on May 19, 2024

@jdalton Thanks for letting me know about it!

from lodash.com.

linonetwo avatar linonetwo commented on May 19, 2024

It's getting slow again! In chrome.

from lodash.com.

jdalton avatar jdalton commented on May 19, 2024

Nothing has changed on our end. If you think it's a Chrome regression you're better off filing the bug with Chrome since I'm not going to do any work on this.

from lodash.com.

bbottema avatar bbottema commented on May 19, 2024

@jdalton, It's become completely unusable for me. Locks up for a minute.

from lodash.com.

jdalton avatar jdalton commented on May 19, 2024

I've got nothing actionable here, sorry. The source hasn't changed so unless you investigate and create a PR the situation will likely not improve for you.

I'm locking the thread since "met too" comments without a patch or further info don't really help. I've visited the docs in Chrome plenty of times and have never had a problem. I checked with Firefox 60.0.2 and it loads quick too.

from lodash.com.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.