Giter Site home page Giter Site logo

Comments (4)

Lodin avatar Lodin commented on May 20, 2024 2

@akarabach, @AlokBisht, all changes are published now in 3.0.0-beta.0 release.

from react-vtree.

Lodin avatar Lodin commented on May 20, 2024 1

Ok, I think I've solved this issue. For the @akarabach's example results are quite nice. Unfortunately, cannot check something bigger because Chrome fails with out of memory error.

@AlokBisht, @akarabach, you can check fix/performance-on-big-data branch if you want. I updated storybook examples, so it should be easy to follow all the changes (they are mostly internal though the treeWalker function has changed a lot).

from react-vtree.

AlokBisht avatar AlokBisht commented on May 20, 2024

I'm facing the same issue. when there are too many nodes in the tree, and all are expanded. We traverse the child nodes if a parent is open but we don't consider if the nodes will be visible or hidden cause of the overflow. even though the the tree may show a small number of nodes at a time, traversing the whole hierarchy is not efficient. I think the yield should happen only when requested by view (or make it use choice).

from react-vtree.

Lodin avatar Lodin commented on May 20, 2024

@AlokBisht, yeah, I already had that discussion in the #11. The main problem with yield that is cannot work backward (or at least I cannot imagine how to set it up). So if you are scrolling down, it's ok. But when you start scrolling up the whole system breaks.

I probably should re-open #11 to make it easier to find. Let's continue the discussion in that issue.

from react-vtree.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.