Comments (8)
@matskiv I can try to fix this minor issue if that's okay (especially if I get a few days to work on it). I didn't find the mentioned main/chart/templates/statefulset.yaml#L32 repo but only the main/charts/**/templates one.
This is an excellent issue to be worked on before diving into the actual vcluster's logic.
from vcluster.
@vsantos Oh, I would love to have automated tests for the charts. This has been on my todo list for a while, but it always gets pushed back 😂 I would try to first look for some tools tailored to Helm, to have sort of a "unit tests" for the Helm charts.
But this should be a separate issue for sure :)
from vcluster.
@matskiv I would like to contribute to this issue, could you please assign it to me?
from vcluster.
@hiteshwani29 Thank you for your interest. It's assigned to you now.
from vcluster.
@jburnitz thanks for creating this issue! Yeah I guess the best solution is that we only define storageClassName
if a name was defined in the values
from vcluster.
This is the same in the chart, so we should fix it.
As for this sentence from the description:
Define a default in values "Filesystem" is the inferred value when undefined per: https://github.com/kubernetes/api/blob/release-1.21/core/v1/types.go#L489
The default value of "Filesystem" is for the volumeMode field, which we don't set.
from vcluster.
@vsantos Yeah, absolutely! I'll assign this to you then. You can take your time, there is no rush with this issue.
I didn't find the mentioned main/chart/templates/statefulset.yaml#L32 repo but only the main/charts/**/templates one.
Yeah, we added more charts since this was reported 😄 I would say that the issue applies to all storageClassName
references in all charts/**.
btw: a tip for quick validation. First time I was testing some chart changes I did in a way too complicated way, so sharing just in case.
helm template vcluster ./charts/k3s/ --set storage.className=test | grep storageClassName
helm template vcluster ./charts/k8s/ | grep storageClassName
I used a very similar command to this just the other day, it's very helpful for quickly checking the output of the chart.
The first one tests k3s chart with .Values.storage.className
set. Second tests k8s chart without the .Values.storage.className
value. And then I grep all outputted manifests... you get the idea :)
from vcluster.
@matskiv Do you guys think is a good idea to add some kind of "automated" mechanism to make it easier to test static YAML files as part of the scope of this PR? We could use bats, it's a very old tool but good in make assertions in bash scripts. Your suggested logic to test locally could be automated to ensure that a given values.yaml
will return specific structures.
Or maybe we should just fix the broken logic and in the future start a new thread about automation alternatives?
from vcluster.
Related Issues (20)
- Unable to connect to vcluster via CLI after exposing it via Loadbalancer HOT 1
- Map headless from hostcluster to vcluster does not work HOT 5
- Vcluster in AKS HOT 3
- K0s vcluster ends up in crash loop if it ever fails HOT 3
- Endpoints are not updated in Host -> vCluster Service mappings of headless services HOT 1
- etcd DNS query to host DNS HOT 4
- etcd queries for nodes that doesn't exist due to the SANs on etcd-server.crt HOT 1
- CrashLoopBackOff on GKE HOT 2
- fallbackdns should be configurable HOT 1
- runtime error: invalid memory address or nil pointer dereference HOT 1
- rancher/k3s:v1.25.14-k3s1 doesn't work with vCluster v0.17.1 HOT 2
- Workload no longer works after upgrading vcluster 0.15.7 to 0.18.1 HOT 5
- Create additional kubeconfig secret in the helm chart(s) for access from host cluster HOT 3
- OOMKilled Init container HOT 2
- The annotations `.Values.syncer.serviceAnnotations` are added to 2 services HOT 1
- Allow in the helm charts to specify a k8s version HOT 4
- Cannot connect to datastore with network isolation HOT 1
- Proxy all k8s metrics from host cluster to vcluster even with fake nodes HOT 3
- Create a sample Generic Sync Example for the Traefik version that ships with the K3s.
- Feature request: Add support for wildcards or regexes in `--sync-labels` HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vcluster.