Use portable macros for printing sizes, offsets, and addresses

[loganchien]

Use portable macros for printing sizes, offsets, and addresses

[GoogleCodeExporter]

We use our own Printf, should be fine. 

Original comment by [email protected] on 13 Feb 2012 at 3:48

• Changed state: WontFix

[GoogleCodeExporter]

Still, this is very misleading and error prone. Using %lx, etc syntax makes 
people think there is a printf() underneath.

I suggest we invent a new syntax for Printf format lines, so that no one will 
ever confuse it with printf(). It can also have a specifier for decimal 
intptr_t/uintptr_t, that normal printf() is lacking.

Original comment by [email protected] on 15 Feb 2012 at 6:52

• Changed state: Accepted

[GoogleCodeExporter]

Really, I see no problem. at all. And we have much more important things to 
care about. 

Original comment by [email protected] on 15 Feb 2012 at 6:55

[GoogleCodeExporter]

For short term mitigation, I suggest we replace all % with @.

Original comment by [email protected] on 15 Feb 2012 at 6:57

[GoogleCodeExporter]

I hope you are kidding. 

Original comment by [email protected] on 15 Feb 2012 at 7:05

• Changed state: WontFix

[GoogleCodeExporter]

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=64-bit_Po
rtability#64-bit_Portability

Original comment by [email protected] on 15 Feb 2012 at 7:08

[GoogleCodeExporter]

I kind of was :)
Per online discussion, I'm adding %zu/%zd to Printf.

Original comment by [email protected] on 15 Feb 2012 at 7:16

• Changed state: Started

[GoogleCodeExporter]

can this be closed? (or fixed and closed?)

Original comment by [email protected] on 24 Feb 2012 at 10:59

[GoogleCodeExporter]

First fixed, then closed.

Original comment by [email protected] on 27 Feb 2012 at 10:23

[GoogleCodeExporter]

Ping. Please either fix or close. 

Original comment by [email protected] on 16 Mar 2012 at 4:54

[GoogleCodeExporter]

http://codereview.appspot.com/5856044/

Original comment by [email protected] on 20 Mar 2012 at 11:00

[GoogleCodeExporter]

Can this be marked as fixed already?

Original comment by [email protected] on 18 Apr 2012 at 10:23

[GoogleCodeExporter]

Original comment by [email protected] on 18 Apr 2012 at 10:46

• Changed state: Fixed