Giter Site home page Giter Site logo

Comments (10)

sshort avatar sshort commented on May 30, 2024 1

Hi,

what's the state of this, please? I was thinking of adding this myself.

Thanks
Steve

from grpc-spring-boot-starter.

jvmlet avatar jvmlet commented on May 30, 2024

You are right, it's missing. Will add this tomorrow

from grpc-spring-boot-starter.

jvmlet avatar jvmlet commented on May 30, 2024

Hi @xaqq
Unfortunately, the grpc doens't have generic API for all providers to specify the address. It means I will need to expose properties per provider for autoconfiguration.. it will take a while, sorry.

from grpc-spring-boot-starter.

xaqq avatar xaqq commented on May 30, 2024

Hello @jvmlet

Thank you for confirming my issue.
I will try and see if I manage to find an "in-app" workaround until a proper solution is available.

from grpc-spring-boot-starter.

xaqq avatar xaqq commented on May 30, 2024

So I went ahead and forked the project to try to implement (partially) this feature.

You can see the commit here https://github.com/xaqq/grpc-spring-boot-starter/tree/netty-bind-addr

It's limited and apply to Netty only, but this seems to work. I'm not too sure about the order in which the bean are evaluated and if maybe the enabled property, when set to true, could conflict with the nettyBindAddress property.

I noticed the ServerBuilder.forPort() method but there is no forAddress() and I don't know what the ServerProvider is. This is why i've scoped my changed to netty only.

from grpc-spring-boot-starter.

jvmlet avatar jvmlet commented on May 30, 2024

Your implementation looks OK, I'll add this functionality to be customizable by all users (OKHttp,Netty and inprocess)

from grpc-spring-boot-starter.

jvmlet avatar jvmlet commented on May 30, 2024

Grpc has its own way to pick up the server builder implementation by using SPI. Need to think how NOT to break this functionality when implementing this feature

from grpc-spring-boot-starter.

ggongit avatar ggongit commented on May 30, 2024

Hey @jvmlet , Could you please let me know if you have any further updates on it as I am looking for binding my grpc server services on loopback address (127.0.0.1) and I do not see any way to achieve it.
Thanks.

from grpc-spring-boot-starter.

jvmlet avatar jvmlet commented on May 30, 2024

I'm collecting feature requests for the upcoming versions. This one will be in the list.

from grpc-spring-boot-starter.

jvmlet avatar jvmlet commented on May 30, 2024

It's better later than never ;-)

from grpc-spring-boot-starter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.