Giter Site home page Giter Site logo

husky precommit about vite-vuetify-ts-starter HOT 21 OPEN

logue avatar logue commented on May 24, 2024
husky precommit

from vite-vuetify-ts-starter.

Comments (21)

logue avatar logue commented on May 24, 2024 1

This is a normal behavior because it refers to meta information such as the last build datetime that is automatically generated at build time. (This is the same reason why it says to run build-only when deploying.)

It is included in .gitignore because its nature causes file changes every time it is built.

If you really care, just comment out ./src/Meta.ts from .gitignore and include Meta.ts in your project.

from vite-vuetify-ts-starter.

logue avatar logue commented on May 24, 2024

What package manager are you using?
Currently, it is confirmed that pnpm causes a problem.

from vite-vuetify-ts-starter.

f1eeman avatar f1eeman commented on May 24, 2024

yarn - v3.3.0
node - v16.17.1

from vite-vuetify-ts-starter.

f1eeman avatar f1eeman commented on May 24, 2024

if i use npm(8.15.0) and node v16.17.1:

  1. I need to add a pre-commit file to the husky directory with the following content:
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

npx --no-install lint-staged --relative
  1. install @babel/types in dev deps

As a result, I get the following:
image

from vite-vuetify-ts-starter.

logue avatar logue commented on May 24, 2024

Node LTS version (current is 18.12.1) or later is supported...

"node": ">=18.12.1",

from vite-vuetify-ts-starter.

f1eeman avatar f1eeman commented on May 24, 2024

I'm sorry, that was my mistake. However, after updating the node (now version is 18.12.1, npm version is 8.19.2), re-cloning the current repository, I ran into the same problems as when using, among other things, the yarn package

image

from vite-vuetify-ts-starter.

logue avatar logue commented on May 24, 2024

It looks like tsconfig.json and env.d.ts are not recognized.

Restart vscode after clearing cache with yarn run clean. Also try takeover mode if possible.

from vite-vuetify-ts-starter.

f1eeman avatar f1eeman commented on May 24, 2024

Nothing helps. The problem with the "alias" seems to me, because if all aliases (@ ) are replaced with relative paths, there are no problems with types 

from vite-vuetify-ts-starter.

logue avatar logue commented on May 24, 2024

It seems that eslint recognizes @ normally, and it seems that vue-tsc is outputting an error, so tsconfig is suspicious. Is this in vanilla state?

from vite-vuetify-ts-starter.

f1eeman avatar f1eeman commented on May 24, 2024

tsconfig state fully corresponds to tsconfig from this repository

from vite-vuetify-ts-starter.

logue avatar logue commented on May 24, 2024

There may be a cause in the environment on the vscode side, such as veutr was included.
Try resetting your vscode settings.

from vite-vuetify-ts-starter.

f1eeman avatar f1eeman commented on May 24, 2024

Did not help....
I don't think it has anything to do with the ide, because firstly, this kind of errorserrors occur in any ide, and secondly, the problem is clearly with the alias in the configs(ts, eslint, vite)

from vite-vuetify-ts-starter.

logue avatar logue commented on May 24, 2024

There was an update of Vuetify yesterday, so I updated this project accordingly. (also merged createVuetify)
Did you reproduce it?

Notice: eslint-plugin-vuetify v2, which supports Vuetify3, but it is in beta.

from vite-vuetify-ts-starter.

dossanovruslan avatar dossanovruslan commented on May 24, 2024

I have exactly the same problem, isn't there any solution yet?

from vite-vuetify-ts-starter.

f1eeman avatar f1eeman commented on May 24, 2024

There was an update of Vuetify yesterday, so I updated this project accordingly. (also merged createVuetify) Did you reproduce it?

Notice: eslint-plugin-vuetify v2, which supports Vuetify3, but it is in beta.

yes, a have cloned actual version for this template, but the problem remains

from vite-vuetify-ts-starter.

logue avatar logue commented on May 24, 2024

I don't know for a moment.

What happens if the value of lint-staged in package.json is just prettier like below?

{
 "lint-staged": {
    "*": "prettier -w -u"
  }
}

from vite-vuetify-ts-starter.

f1eeman avatar f1eeman commented on May 24, 2024

I don't know for a moment.

What happens if the value of lint-staged in package.json is just prettier like below?

{
 "lint-staged": {
    "*": "prettier -w -u"
  }
}

The problem is with vue-tsc. If type checking via vue-ts is removed, then husky exits successfully without doubt

  "lint-staged": {
    // "*.vue": "vue-tsc --noEmit",
    "*.{js,ts,json,jsonc,json5,yaml,yml,toml,yml,yaml,vue,htm,html,md}": "eslint --fix --cache --cache-location ./node_modules/.vite/vite-plugin-eslint",
    "*.{css,sass,scss,vue,htm,html}": "stylelint --fix --cache --cache-location ./node_modules/.vite/vite-plugin-stylelint",
    "*": "prettier -w -u"
  },

from vite-vuetify-ts-starter.

logue avatar logue commented on May 24, 2024

Thank you for your report.

from vite-vuetify-ts-starter.

f1eeman avatar f1eeman commented on May 24, 2024

I've found a solution to the problem, but I'm not sure if it is right:

  "lint-staged": {

    !!!!!!!!!!!!!
    "*.{ts,vue}": "vue-tsc --noEmit",
    !!!!!!!!!!!!!

    "*.{js,ts,json,jsonc,json5,yaml,yml,toml,yml,yaml,vue,htm,html,md}": "eslint --fix --cache --cache-location ./node_modules/.vite/vite-plugin-eslint",
    "*.{css,sass,scss,vue,htm,html}": "stylelint --fix --cache --cache-location ./node_modules/.vite/vite-plugin-stylelint",
    "*": "prettier -w -u"
  },

AND

image

from vite-vuetify-ts-starter.

logue avatar logue commented on May 24, 2024

In principle, it's probably irrelevant since it's based on createVue.

see also:
https://github.com/vuejs/create-vue-templates/tree/main/typescript-router-pinia-vitest

from vite-vuetify-ts-starter.

f1eeman avatar f1eeman commented on May 24, 2024

npm run type-check
"type-check": "vue-tsc --noEmit -p tsconfig.vitest.json --composite false",

image

from vite-vuetify-ts-starter.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.