Giter Site home page Giter Site logo

The PickerDialog disappears when scrolling if the ColorPicker is contained in an element with a scroll bar about material-ui-color-picker HOT 4 CLOSED

loicmahieu avatar loicmahieu commented on July 18, 2024
The PickerDialog disappears when scrolling if the ColorPicker is contained in an element with a scroll bar

from material-ui-color-picker.

Comments (4)

LoicMahieu avatar LoicMahieu commented on July 18, 2024 1

Thanks for sharing. Not enough time to work on this.
graphviz-visual-editor looks amazing. Good work!

from material-ui-color-picker.

LoicMahieu avatar LoicMahieu commented on July 18, 2024

Hi @magjac

Integrate this module in a scrolling container is not the use I had planned ;) But indeed it could be useful at time.
Unfortunately I have no time at the moment to help you but I will do my best.

The fixed div in the PickerDialog is a quick and dirty way to handle click outside of the dialog. It must be a better way to do that.

I invite you to send a PR, even if it is dirty and not completely working. It will be a start for discussion.

from material-ui-color-picker.

magjac avatar magjac commented on July 18, 2024

Thanks for your consideration. I ended up replacing the material-ui-color-picker component with a custom implementation based on the SketchExample from https://casesandberg.github.io/react-color/#examples, because I wanted to add a swatch and some other stuff and to get better control over the styling. I'm not experienced enough to create a general customizable component. Sorry about that.

I'll post a link to my implementation here when I've pushed it to github in the event you want to have a look at it later.

Again thanks. 🙂

from material-ui-color-picker.

magjac avatar magjac commented on July 18, 2024

Here is my implementation.

The state has been lifted up to the parent component here and here

from material-ui-color-picker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.