Linker fails with header-only build

[SteveS-Serrano]

Linker fails with header-only build

[Loki-Astari]

I will have a look this weekend.
I am in the processes of tidying up a few things and make the header only version neater.

[SteveS-Serrano]

@Loki-Astari - I'd really like to use this package, but I'm stuck until it can build in our environment. Did you have a chance to look at the issue yet? Can you tell me how I might go about working around it just so I can move forward? Should I drop back to an older version? I saw an old post on stack overflow about the same issue - was that ever resolved?

[Loki-Astari]

Are you building on Windows?

If you are then I am trying to get a few build issues sorted before I can rebuild the header only version.

But if you only Mac or Linux then I can switch focus and get the header only version working first.
Then move back to solving build issues on Windows.

[SteveS-Serrano]

Linux, Ubuntu 22.04 From: Loki ***@***.***> Sent: Tuesday, May 16, 2023 3:49 PM To: ***@***.***> Cc: ***@***.***>; ***@***.***> Subject: Re: [Loki-Astari/ThorsSerializer] Linker fails with header-only build (Issue #81) Are you building on Windows? — Reply to this email directly, view it on GitHub<#81 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQCFUJR3PV57QRVDJBYOJUDXGP77RANCNFSM6AAAAAAX6YNLNU>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[Loki-Astari]

You do know that it is available pre-built on linix via brew.

https://docs.brew.sh/Homebrew-on-Linux

/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"
brew install libyaml
brew install magic_enum
brew install thors-serializer

Then you can simply link against it in your CMake file:

I am still working on the header only version.
I'll update this as I get closer (this week).

[SteveS-Serrano]

I know about the pre-built version. Our project constraints require a header-only version for json serdes.

[Loki-Astari]

OK.
Fixed the Windows build issues last night.
Working on the Header Only version now.

[Ssscy]

you need add HEADER_ONLY macro

[SteveS-Serrano]

you need add HEADER_ONLY macro

Where? Can you give me an example?

[SteveS-Serrano]

@Ssscy 👍

you need add HEADER_ONLY macro

Thanks!!

I defined -DHEADER_ONLY=1 on the command line and this seems to have resolved the problem. This information should get added to doc/building.md

[Loki-Astari]

Update so the header-only version now builds out of the box.
The current build tests: .github/workflows/build.yaml also validate the header-only version works out of the box.
Latest build: https://github.com/Loki-Astari/ThorsSerializer/actions/runs/5458805284/jobs/9934301849