Giter Site home page Giter Site logo

Comments (6)

fefo-p avatar fefo-p commented on May 31, 2024

Workaround, requiring myth's route file (in app's route file) so it can be overridden.
Adding the following to \App\Config\Routes does the trick

// Load the Myth's routing file first, so that the app and ENVIRONMENT
// can override as needed.
if (file_exists(APPPATH . '../vendor/myth/auth/src/Config/Routes.php'))
{
	require APPPATH . '../vendor/myth/auth/src/Config/Routes.php';
}

Still, would be nice to have a better way to do it

from myth-auth.

lonnieezell avatar lonnieezell commented on May 31, 2024

What version of CI are you running on? There was a bug a couple of releases back that fixed the order of routes, I believe.

from myth-auth.

fefo-p avatar fefo-p commented on May 31, 2024

At the time of this PR, devel branch. (I belive something like a week old now).
Yesterday I downloaded CI4 rc1, so I can give it a try with that.
I'll let you know later today

from myth-auth.

fefo-p avatar fefo-p commented on May 31, 2024

Just tried it. A user who only belongs to users group can still access the register url (can create users).
This is tried after commenting-out in \App\Config\Routes the line that loaded Myth-Auth's one (where it is allowed to everyone for self-registration) before actually setting the App's routes (where it's only allowed to admin groups).

Installed myth/auth from composer

"myth/auth": "1.0-beta"

PHP

PHP 7.3.8 (cli) (built: Aug  6 2019 23:15:07) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.8, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.8, Copyright (c) 1999-2018, by Zend Technologies

Apache

Server version: Apache/2.4.41 (Unix)
Server built:   Aug 15 2019 06:42:08

OS

macOS 10.15 Beta (19A546d)

from myth-auth.

lonnieezell avatar lonnieezell commented on May 31, 2024

In a relatively clean project that I've just started, I have myth:auth installed like default.

In my app/Config/Routes.php file I add the following:

$routes->get('register', function() {
    dd('local route');
});

When I visit /register I hit the route in app/Config/Routes.php as expected. Meaning that the app can override Myth:Auth's routes. That leads me to believe your core issue isn't routes not being able to override, but something else in your app.

from myth-auth.

fefo-p avatar fefo-p commented on May 31, 2024

I tried with a brand new download of both CI4 RC1 and Auth Beta 1 and everything works fine.
Therefore, you're right when you say that I have something else going on in my app. Will have to keep digging in.
Thx

from myth-auth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.