Should indexing logic require actual Sweep events at the aggregator level?

[0xJurassicPunk]

Should indexing logic require actual Sweep events at the aggregator level?

[0xJurassicPunk]

For now, the consensus is just to have a single event with the msg.sender in it if one trade or more is executed.

[rob-looksrare]

POC to get the function input parameters in java

    @Getter
    @AllArgsConstructor
    public static class TakerOrder extends DynamicStruct {
        Bool isOrderAsk;
        Address taker;
        Uint256 price;
        Uint256 tokenId;
        Uint256 minPercentageToAsk;
        DynamicBytes params;
    }

    @Getter
    @AllArgsConstructor
    public static class MakerOrder extends DynamicStruct {
        Bool isOrderAsk;
        Address signer;
        Address collection;
        Uint256 price;
        Uint256 tokenId;
        Uint256 amount;
        Address strategy;
        Address currency;
        Uint256 nonce;
        Uint256 startTime;
        Uint256 endTime;
        Uint256 minPercentageToAsk;
        DynamicBytes params;
        Uint8 v;
        Bytes32 r;
        Bytes32 s;
    }
    
    private static final org.web3j.abi.datatypes.Function MATCH_BID_WITH_TAKER_ASK =
            new org.web3j.abi.datatypes.Function("matchBidWithTakerAsk",
                    Collections.emptyList(),
                    Arrays.asList(
                            new TypeReference<TakerOrder>() {},
                            new TypeReference<MakerOrder>() {}
                    )
            );

    public void test() {
        EthTransaction ethTransaction = web3j.ethGetTransactionByHash("0x40a24bf63ade494c5ae34cfea7808305ab881c16cc92eee504f3cd916f940e23").send();
        Transaction transaction = ethTransaction.getResult();
        List<Type> types = FunctionReturnDecoder.decode(transaction.getInput().substring(10), MATCH_BID_WITH_TAKER_ASK.getOutputParameters());
    }

types array will contain the matchBidWithTakerAsk function input params as we can see here https://etherscan.io/tx/0x40a24bf63ade494c5ae34cfea7808305ab881c16cc92eee504f3cd916f940e23

[0xJurassicPunk]

Does it impact the indexing performance? @rob-looksrare

[rob-looksrare]

Does it impact the indexing performance? @rob-looksrare

Based on gut feeling it does not impact the performance in a significant way, should be one extra call to rpc provider (did not do any tests regarding performance).

[0xJurassicPunk]

Hmmm, let's stick to the current specs where there is one event from the aggregator then. 🤔