updateOrCreate return value is broken

[loopbackio]

updateOrCreate return value is broken

[punund]

Affects me too.

[BerkeleyTrue]

+1 This connector needs some love!

[BerkeleyTrue]

See this PR for fix! #40

[raymondfeng]

@BerkeleyTrue Thank you for the patch. I think the issue is even more involved. The upsert is mapped to a SQL statement as follows:

WITH update_outcome AS 
(UPDATE "public"."postwithboolean" 
SET "title"=$1,"content"=$2,"approved"=$3 
WHERE  "id"=$4 RETURNING "id"), 
insert_outcome AS 
(INSERT INTO "public"."postwithboolean" ("title","content","approved","id") 
SELECT $1,$2,$3,$4  WHERE NOT EXISTS 
(SELECT * FROM update_outcome) 
RETURNING "id") 
SELECT * FROM update_outcome UNION ALL SELECT * FROM insert_outcome

The usage of writable CTE requires Postgresql 9.1 or later. See http://www.postgresql.org/docs/9.2/static/queries-with.html.

One fix is just remove the native implementation from the postgresql connector so that https://github.com/strongloop/loopback-datasource-juggler/blob/master/lib/dao.js#L264 will kick in. It basically tries to find by id first and create if not found.

[BerkeleyTrue]

Thanks Raymond, I wasn't aware of DAO method. I have update my PR accordingly.

[raymondfeng]

It should be fixed by [email protected] now.

[BerkeleyTrue]

This issue is resolved and should be closed.