ADR command

[lora-net]

ADR command

[mluis1]

The LINK_ADR_REQ MAC command is used to change the channel mask. The implementation is correct as is.

Please note the upper case and lower case letters in the variables names.
channelsMask[0] = chMask;
ChannelsMask[0] = channelsMask[0];

The coding convention in use on this project are that global variables start by a upper case letter while local variables start by a lower case letter.

[coljander]

Hi

Thanks.

I see my mistake. I’ll check what is coming back from the gateway as at the end of that routine my ChannelMask[0] is only set to 15 so I’m only able to use 4 of the available channels.

Colin

From: Miguel Luis [mailto:[email protected]]
Sent: 15 March 2016 09:56
To: Lora-net/LoRaMac-node
Cc: Colin Anderson
Subject: Re: [LoRaMac-node] ADR command (#55)

The LINK_ADR_REQ MAC command is used to change the channel mask. The implementation is correct as is.

Please note the upper case and lower case letters in the variables names.
channelsMask[0] = chMask;
ChannelsMask[0] = channelsMask[0];

The coding convention in use on this project are that global variables start by a upper case letter while local variables start by a lower case letter.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#55 (comment)