Comments (1)
Concurrent request/response order cannot currently be guaranteed (especially on CSMS endpoints), since they run on two separate goroutines. Hence your follow-up request could indeed reach its destination before the response to the previous request.
The protocol doesn't prohibit two endpoints from sending each other a request simultaneously.
Just out of curiosity, why could a GetConfigurationReq
not reach its destination before a BootNotificationResp
? The two messages are unrelated, so there isn't really a race condition the way I see it.
To the matter at hand: you have two options, but either way you'll have to work with goroutines.
Inline follow-up request
Simply send the follow-up request directly (as you suggested):
func (h *CentralSystemHandler) OnBootNotification(chargePointId string, request *core.BootNotificationRequest) (confirmation *core.BootNotificationConfirmation, err error) {
// do what you have to
followUpReq := core.NewGetConfigurationRequest()
go centralSystem.SendRequestAsync(chargePointID, followUpReq, myCallback)
return core.NewBootNotificationConfirmation(types.NewDateTime(time.Now()), defaultHeartbeatInterval, core.RegistrationStatusAccepted), nil
}
Note:
- as mentioned above, there is no guarantee that this will arrive after the previous response (although it is very likely)
- the send operation can return an error, which should be handled. Your callback function might become packed if you have to handle errors as well
Task scheduling
Or you can schedule follow-up operations via channels on a separate goroutine. For example:
func (h *CentralSystemHandler) OnBootNotification(chargePointId string, request *core.BootNotificationRequest) (confirmation *core.BootNotificationConfirmation, err error) {
// do what you have to
h.myChan <- followUpTrigger // could be anything, from a signal to an entire payload
return core.NewBootNotificationConfirmation(types.NewDateTime(time.Now()), defaultHeartbeatInterval, core.RegistrationStatusAccepted), nil
}
func (handler *CentralSystemHandler) MyTaskScheduler() {
for {
select {
case followUpTrigger := <-h.myChan:
// Process the trigger
centralSystem.GetConfiguration("someID", myCallback)
}
}
}
Similarly to before, you technically cannot guarantee that your follow-up will arrive after the response to the "previous" message.
I hope this helps.
from ocpp-go.
Related Issues (20)
- Unhandled json errors in GetConfiguration HOT 3
- Parsing of local timestamps not supported - spec violation? HOT 9
- Central-system 1.6 example - "fatal error: concurrent map writes" when connecting multiple chargers rapidly HOT 1
- Code Generation HOT 1
- TriggerMessage.Req validation disallows passing connector 0 HOT 6
- ChangeConfigurationRequest doesn't allow empty values
- Bad Request response for https via curl request HOT 1
- Release new version? HOT 2
- Fix vet report HOT 2
- Issue with DataTransfer on both ocpp 1.6 and 2.0.1 HOT 2
- Send Command To Charging Station
- I call remote start transaction but got error "ocpp message (2193907606): InternalError - An internal error occurred and the receiver was not able to process the requested Action successfully" HOT 1
- SecurityEventNotification.req HOT 13
- Decouple websocket server and message processing HOT 7
- Parses an OCPP-J message,Occurrence anomaly HOT 4
- Is their any way to bypass the SubjectAlternateName check while using tls? HOT 1
- Fetch chargePointId inside SetBasichandler HOT 6
- Fetch raw ocpp message HOT 4
- Bug with validation for connectorId of GetCompositeSchedule.conf #275
- shoudl idTag validator be altered? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ocpp-go.