Giter Site home page Giter Site logo

Comments (1)

lorenzodonini avatar lorenzodonini commented on September 26, 2024

Concurrent request/response order cannot currently be guaranteed (especially on CSMS endpoints), since they run on two separate goroutines. Hence your follow-up request could indeed reach its destination before the response to the previous request.
The protocol doesn't prohibit two endpoints from sending each other a request simultaneously.

Just out of curiosity, why could a GetConfigurationReq not reach its destination before a BootNotificationResp? The two messages are unrelated, so there isn't really a race condition the way I see it.

To the matter at hand: you have two options, but either way you'll have to work with goroutines.

Inline follow-up request

Simply send the follow-up request directly (as you suggested):

func (h *CentralSystemHandler) OnBootNotification(chargePointId string, request *core.BootNotificationRequest) (confirmation *core.BootNotificationConfirmation, err error) {
         // do what you have to
        followUpReq := core.NewGetConfigurationRequest()
        go centralSystem.SendRequestAsync(chargePointID, followUpReq, myCallback)
	return core.NewBootNotificationConfirmation(types.NewDateTime(time.Now()), defaultHeartbeatInterval, core.RegistrationStatusAccepted), nil
}

Note:

  • as mentioned above, there is no guarantee that this will arrive after the previous response (although it is very likely)
  • the send operation can return an error, which should be handled. Your callback function might become packed if you have to handle errors as well

Task scheduling

Or you can schedule follow-up operations via channels on a separate goroutine. For example:

func (h *CentralSystemHandler) OnBootNotification(chargePointId string, request *core.BootNotificationRequest) (confirmation *core.BootNotificationConfirmation, err error) {
         // do what you have to
        h.myChan <- followUpTrigger // could be anything, from a signal to an entire payload
	return core.NewBootNotificationConfirmation(types.NewDateTime(time.Now()), defaultHeartbeatInterval, core.RegistrationStatusAccepted), nil
}

func (handler *CentralSystemHandler) MyTaskScheduler() {
	for {
		select {
		case followUpTrigger := <-h.myChan:
			// Process the trigger
			centralSystem.GetConfiguration("someID", myCallback)
		}
	}
}

Similarly to before, you technically cannot guarantee that your follow-up will arrive after the response to the "previous" message.

I hope this helps.

from ocpp-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.