Giter Site home page Giter Site logo

Comments (6)

jpstroop avatar jpstroop commented on September 11, 2024

Hmmm....that was a bug that I thought I fixed right before the tag. Hold on...

from loris.

jpstroop avatar jpstroop commented on September 11, 2024

Hmm, the log section is there in both the latest version on the development banch:

https://github.com/pulibrary/loris/blob/development/etc/loris.conf#L29

and in the revision that was tagged:

https://github.com/pulibrary/loris/blob/9a1e320ba4df68efb861fc56ed1a2919045f8ae0/etc/loris.conf#L29

So you're not getting a fresh loris.conf file.

I just did a test on my machine, and indeed it looks like setuptools won't overwrite if the file exists. So, the safest thing to do would be for you to delete /etc/loris/loris.conf then run setup.py install and then configure. I just had a look around to see if there was a way to override this behavior (--force or something would be nice), but it doesn't look like it.

I'll add some info about this to the release notes. Thanks for catching it!

from loris.

regisrob avatar regisrob commented on September 11, 2024

Sorry it was my fault: I changed the conf directory and I forgot to change "prod_conf_fp" in "loris/log.py". That was the problem... But it means that test.py is testing against "/etc/loris/loris.conf" and not "etc/loris.conf", is that true ?

from loris.

jpstroop avatar jpstroop commented on September 11, 2024

It's true for logging, unfortunately, and I don't like it.

https://github.com/pulibrary/loris/blob/development/loris/img_info.py#L16

I do point this out in the README, but it really does feel like a hack.

The problem right now is that loggers are instantiated at the module level, e.g.:

etc. And because of this I don't have the ability to pass get_logger() parameters, which means the only way to decide where to go/what to do is based on whether or not there's a file at /etc/loris/loris.conf or not.

There has to be a better way. I'll put in an issue for the next bit of work (likely to happen in later December...).

from loris.

jpstroop avatar jpstroop commented on September 11, 2024

Submitted as issue #44

from loris.

jpstroop avatar jpstroop commented on September 11, 2024

@regisrob see #44. This is in much better shape now. I will release shortly.

from loris.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.