Should I contribute or fork?

[xbc5]

Should I contribute or fork?

[k127]

there is a space after the citation: (Foo, 2009) .

I fixed this in #64.

[HughP]

Please make a PR.

On Sun, Oct 2, 2022 at 11:17 AM xbc5 ***@***.***> wrote: I have some issues with the current implementation that I will fix. My question is whether these are suitable for a PR, or whether I should maintain my own fork. 1. it doesn't throw for invalid cite key -- it should - - in-text citation can linebreak on ( : (\nfoobar) -- perhaps use some HTML markers (linebreak hints) to indicate that it shouldn't break there; - the popup, dl, and/or in-text citation could be a cite element; - the popup tile could be wrapped in a span for easier styling; - all elements, including sub elements could have classes for easier styling; - there is a space after the citation: (Foo, 2009) . - the section tag (bibliography) doesn't have a heading; - should the bib be part of the main content (shortcode) or outside of it (partial) as an "aside"? - make proper use the the <cite> element; — Reply to this email directly, view it on GitHub <#62>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAJ2JS6HFZSLSHDCHZY26DWBHGSTANCNFSM6AAAAAAQ3ADMT4> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- All the best, -Hugh

…

Sent from my iPhone

[loup-brun]

All PRs accepted! Sorry I don’t have much time to maintain this.

[k127]

Hi @xbc5 !

Thanks for collecting all of these tasks!

Firstly, I'd like to state that I support @HughP 's suggestion to split this up into several PRs.

Since I'm currently also working on some of the tasks you collected in this issue, for reducing redundancy:

Is there any task that you have already engaged in? If so, would you mind creating draft PRs for to indicate which of the tasks you're on? That would be great and allow me to proceed! Thank you!

[xbc5]

Hi @xbc5 !

Thanks for collecting all of these tasks!

Firstly, I'd like to state that I support @HughP 's suggestion to split this up into several PRs.

Since I'm currently also working on some of the tasks you collected in this issue, for reducing redundancy:

Is there any task that you have already engaged in? If so, would you mind creating draft PRs for to indicate which of the tasks you're on? That would be great and allow me to proceed! Thank you!

I haven't started any yet, and likely won't for a number of weeks. I'll mention you when I do, and yes I will open PRs early and push as I'm working on them.

Also, mention this issue in your PRs, and I will check the tasks off when they're merged.

NOTE: that I'd like to reserve 9. and 10. (product cards) for myself, because I have some specific ideas, and those two issues were the inspiration for me wanting to contribute. Thanks.

[xbc5]

That was the first one I thought of. Any else?

What do you think @loup-brun ?

[xbc5]

No problem. I will get started soon. I will create separate issues for each before I submit a PR. I'd welcome some feedback on them.

Thanks!

[HughP]

given the size of your list, please make several PRs... preferably one each per "feature"... it allows smoother approval and integration.

…

On Mon, Oct 3, 2022 at 9:51 PM xbc5 ***@***.***> wrote: That was the first one I thought of. Any else? What do you think @loup-brun <https://github.com/loup-brun> ? — Reply to this email directly, view it on GitHub <#62 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAJ2JT7FPOC5NESMZHUDEDWBOZUPANCNFSM6AAAAAAQ3ADMT4> . You are receiving this because you commented.Message ID: ***@***.***>

[xbc5]

given the size of your list, please make several PRs... preferably one each per "feature"... it allows smoother approval and integration.

Absolutely.

I haven't yet started working on this because it's quite low down on my current list of priorities. Once I complete the core features for my website I will start work on this. Right now I am adding to the list, feel free to provide feedback.

Thanks.

[xbc5]

Just an update: I still intend to start this in the not too distant future.

[xbc5]

I am having second thoughts about issuing PRs if the maintainer isn't active. @loup-brun any chance you can share responsibilities? I wouldn't mind doing it, but if you have someone else in mind..

[loup-brun]

I’m sorry I was unavailable to maintain this project, I would like to circle back in the coming weeks. @xbc5 I’ve invited you as a collaborator, so you can review PRs. Thank you for you time!

[xbc5]

Accepted, thanks. I'll need to get familiar with the code before reviewing PRs. I'm almost finished my prior engagements, with two small issues left (on my own, separate project). After I have done those I will tick off a couple of these issues to get myself familiar.