Comments (3)
I'm OK with this being a breaking change, as part of a future possible v0.34.0, as it simplifies the API so that the background
metadata can always be parsed by the color
package and therefore operations that use it such as flatten()
.
Perhaps a single-channel input could return something like { grey: value }
instead? The color
package accepts values in the range 0-100 so we would need to scale from libvips' 0-255 range.
from sharp.
The simplest solution here is probably to always return an RGB Object in metadata.background
regardless of the number of input channels.
Happy to accept a PR for this, if you're able. We should add a test case for this too as it doesn't appear to be covered by any of the scenarios in test/unit/metadata.js at the moment.
from sharp.
Removing greyscale number return type from .metadata()
would be a breaking change for anybody that confidently relies on receiving just the number.
Adding additional parameter type for .flatten()
background to include a number, is not a breaking change.
from sharp.
Related Issues (20)
- Issue setting a color of an element in an SVG HOT 5
- Cannot use custom fonts "Fontconfig error: Cannot load default config file: No such file: (null)" HOT 1
- Remove white pixels to have a transparent background HOT 2
- rotate().extract() resulting in bad extract area for iOS images rotated by metadata HOT 2
- Question: Why does the result of image.raw().extractChannel('red').toBuffer.length != image.width * image.height? HOT 3
- How to change OwnerName by withExifMerge? HOT 3
- Cross-compilation broken on [email protected] and 10.5.0 HOT 7
- Problems creating sharp Lambda layer package with custom libvips HOT 6
- What is the recommended hardware to run highly available production setup HOT 3
- Sharp keeps input file locked HOT 1
- .trim() removes 1 too many pixels HOT 5
- .trim().toBuffer() does not produce info response Object offset properties HOT 2
- Include trimOffsetRight & trimOffsetBottom HOT 2
- Add settings for symmetric .trim() HOT 1
- Animated Gif from raw buffer HOT 1
- Animated gif from raw buffer? HOT 2
- When loading a picture using a file path, the size of the picture exceeds a certain size, and then deleting the picture will cause a problem of prohibiting deletion. HOT 2
- Using node js sharp package composite function is not giving an animated result HOT 4
- `0.33.3` Throws `TypeError: A string was expected` HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sharp.