Giter Site home page Giter Site logo

Comments (7)

luisgerhorst avatar luisgerhorst commented on June 1, 2024 1

With #460 this should be fixed. But to repeat: #460 was not tested. I appreciate the fast merge but I intended to look at the CI output first :D - We will see I guess.

from loxilb.

TrekkieCoder avatar TrekkieCoder commented on June 1, 2024 1

The hotfix worked. Will be looking forward for your full set of perf script changes. Looks great !!

from loxilb.

TrekkieCoder avatar TrekkieCoder commented on June 1, 2024

Your observation is correct. These are not needed and it would be best to remove them as these might consume resources which can in some.way adversely impact the perf test itself.

from loxilb.

TrekkieCoder avatar TrekkieCoder commented on June 1, 2024

Closing this as per this commit

from loxilb.

luisgerhorst avatar luisgerhorst commented on June 1, 2024

I'm sorry I think there was some confusion. The MR was not ready for merging and thus did not fix this issue, it was only a request for comments regarding the benchmarking approach. Please reopen, I will close it myself when appropriate. (I'm sorry if this was not clear, I will make it more explicit next time.)

from loxilb.

TrekkieCoder avatar TrekkieCoder commented on June 1, 2024

Ok got it. Noticed a few breaks in loxilb's cicd. I will temporarily fix this. Please double check and commit once all your changes are ready.

from loxilb.

luisgerhorst avatar luisgerhorst commented on June 1, 2024

Yes, this is expected. I will create a PR with a hotfix, you either apply that or revert the whole series.

from loxilb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.