Comments (6)
from lwan.
I've tested it directly with Lwan and yes, I took a look those headers.I've tested it directly with Lwan and yes, I took a look those headers and blowed my mind because Upgrade
header was missing from the original request from Safari and everything worked well with Chrome.
The Upgrade method is necessary for websockets according to the RFC, so I don't really know if we should remove the check for it. Have you tried other websockets implementations?
Yes, that's why I'm doubled... I used websocat and openresty’s / chrome's / firefox's ws client implemlementations for testing and everything went fine except Safari.
from lwan.
from lwan.
Does it have a Sec-WebSocket-Version header? Is the value different than what other clients send?
Yes, with a correct value. It had every necessary headers except the Upgrade.
Do other servers work with Safari even without this header?
I used nginx before for tls termination and it worked but I overwrote http headers with it. I will check it again.
from lwan.
from lwan.
I just tried the websocket demo with Safari 15.4 here and ot seems to work!
I've tested it with Safari 13.1.4, it's quite old but significant number of users use have this version. I've tested it again with other sites that uses websocket and that header is still missing. Apple quality as well ... :) Only reason why I didn't see this error before I use ngx and it sent that Upgrade
field, hided this problem.
Now, if removing the check is needed for interoperability, then that's probably OK, although I'd prefer working around broken clients if at all possible.
Thanks.
from lwan.
Related Issues (20)
- Unexpected socket closing HOT 8
- HTTP request to third party within a handler HOT 4
- Centos编译报错 HOT 3
- max_post_data_size HOT 1
- Illegal instruction (core dumped) in latest docker image HOT 11
- Debian stable build fails not finding `lua.h` HOT 2
- Unexpected socket closing, round#2 HOT 3
- 12% of cycles spent percent-decoding URLs HOT 4
- Thread scheduler is broken on linux HOT 2
- Lost sockets HOT 13
- Error when building on Mac HOT 2
- get_number_of_cpus HOT 2
- socket activation fails with `Could not parse socket activation data from systemd: Invalid argument (error number 22)` HOT 3
- Problem with request HOT 1
- Is Gihtub embedded in smolsite? HOT 1
- No such file or directory lwan.h 166 | #include "lwan-http-status.h" HOT 2
- FastCGI cache
- ld: error: undefined symbol: hash_int_new hash_add hash_find hash_free HOT 2
- error: use of undeclared identifier 'MSG_FASTOPEN' HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lwan.