Giter Site home page Giter Site logo

Comments (7)

coudot avatar coudot commented on August 27, 2024

Indeed this is a bug. If no entries found, the correct error message should be displayed.

from white-pages.

coudot avatar coudot commented on August 27, 2024

Done. The test on error number was wrong.

from white-pages.

nqb avatar nqb commented on August 27, 2024

At cfae137, message prints to the user when using pattern like "foo*" : "LDAP communication error".

To my mind, it's a "Bad search filter error". Could you override PHP LDAP error message to print a more friendly message like : "Forbidden pattern in search" ?

from white-pages.

nqb avatar nqb commented on August 27, 2024

Currently, error message "LDAP communication error" leads users to believe a technical error on software. This implies bad reputation for White Pages. Search error message seems more accurate (i.e. Incorrect search : * not allowed).

from white-pages.

coudot avatar coudot commented on August 27, 2024

I'm not sure that overriding PHP LDAP messages is a good idea, but it is maybe the only option. We should also see how to prevent user from doing an invalid search

from white-pages.

nqb avatar nqb commented on August 27, 2024

#21

from white-pages.

coudot avatar coudot commented on August 27, 2024

Fixed by #21

from white-pages.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.