Giter Site home page Giter Site logo

Comments (6)

ltdrdata avatar ltdrdata commented on July 24, 2024 1

I'll check this later.

from comfyui-inspire-pack.

ai-waifu-life avatar ai-waifu-life commented on July 24, 2024

I'll check this later.

Just checking if you've had a sec to take a look. Lemme know if you need anything from my end!

from comfyui-inspire-pack.

ltdrdata avatar ltdrdata commented on July 24, 2024

lbw-simple

Is this issue also being reproduced in this workflow? In my tests, while there is a slowdown when model patches are applied block by block compared to the default LoRA, even this process is instantaneous, so it's not to the extent that it would be problematic.

from comfyui-inspire-pack.

ai-waifu-life avatar ai-waifu-life commented on July 24, 2024

Is this issue also being reproduced in this workflow? In my tests, while there is a slowdown when model patches are applied block by block compared to the default LoRA, even this process is instantaneous, so it's not to the extent that it would be problematic.

I noticed that in that you have the seed set to fixed. If no changes are made to the LORA Loader at all, then it is quick after the first run. If I randomize the seed, like I always have, then it will treat it like a first process every time.

from comfyui-inspire-pack.

ltdrdata avatar ltdrdata commented on July 24, 2024

Is this issue also being reproduced in this workflow? In my tests, while there is a slowdown when model patches are applied block by block compared to the default LoRA, even this process is instantaneous, so it's not to the extent that it would be problematic.

I noticed that in that you have the seed set to fixed. If no changes are made to the LORA Loader at all, then it is quick after the first run. If I randomize the seed, like I always have, then it will treat it like a first process every time.

It is correct to always re-execute when randomizing the seed. This is because the patch weights applied to the model change. That seed is a feature to randomize the 'r' when it is used in block weight.

from comfyui-inspire-pack.

ai-waifu-life avatar ai-waifu-life commented on July 24, 2024

It is correct to always re-execute when randomizing the seed. This is because the patch weights applied to the model change. That seed is a feature to randomize the 'r' when it is used in block weight.

Oh! Wait, so that could mean my workflow wasn't working correctly previously? 😂 Well that's great to know lol.
Appreciate your time on this!

from comfyui-inspire-pack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.