Giter Site home page Giter Site logo

Comments (2)

SnoopJ avatar SnoopJ commented on June 20, 2024 1

Do you want to edit your PR to put this in place?

As I take a look at the pre-commit documentation, this might be trickier than I thought, because it seems like there's no equivalent concept of an "extra" on their end. The only option I can think up is to make two py.test hooks.

However, as I think about it, I'm not really sure why this discrepancy was a problem for the downstream user, since it's only in the local hook, not one you're publishing for others to use. Let me ask them, and if it seems like there's a valid concern there, I'll open a separate issue.

clarification: even if I change the relevant entry in additional_dependencies to something that will definitely break when creating an environment (I used thisisnotarealmodule), I can't reproduce the error they were seeing, because the hook is local to this project. Users who follow the instructions in your README should not experience this problem (though it's good to have consistent versions anyway)

from pre-commit-hooks.

Lucas-C avatar Lucas-C commented on June 20, 2024

fuzzywuzzy works perfectly well without any extension modules, and depends on this speedup as an extra. Perhaps this project could do the same?

Sounds good!
Do you want to edit your PR to put this in place?

from pre-commit-hooks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.