Comments (2)
Do you want to edit your PR to put this in place?
As I take a look at the pre-commit
documentation, this might be trickier than I thought, because it seems like there's no equivalent concept of an "extra" on their end. The only option I can think up is to make two py.test
hooks.
However, as I think about it, I'm not really sure why this discrepancy was a problem for the downstream user, since it's only in the local
hook, not one you're publishing for others to use. Let me ask them, and if it seems like there's a valid concern there, I'll open a separate issue.
clarification: even if I change the relevant entry in additional_dependencies
to something that will definitely break when creating an environment (I used thisisnotarealmodule
), I can't reproduce the error they were seeing, because the hook is local to this project. Users who follow the instructions in your README
should not experience this problem (though it's good to have consistent versions anyway)
from pre-commit-hooks.
fuzzywuzzy
works perfectly well without any extension modules, and depends on this speedup as an extra. Perhaps this project could do the same?
Sounds good!
Do you want to edit your PR to put this in place?
from pre-commit-hooks.
Related Issues (20)
- Newline is forced between license comment and code HOT 2
- split commit hooks for less dependencies
- insert-license hook ignores top-level files selected by `types` or `types_or` HOT 2
- add ignore-files argument to remove-crlf? HOT 2
- python-Levenshtein-wheels not available for python 3.10 HOT 6
- Possible incorrect formatting from remove tabs HOT 13
- insert_license - Only first year range is replaced in existing license HOT 6
- insert_license - Inserting new license with --use-current-year replaces start years in ranges HOT 3
- Matching multiple license headers? HOT 8
- Rename this repo? HOT 3
- insert-license should not add a LF at the end of the license header file if it does not have one, to prevent an ugly empty separator line HOT 2
- Ignore commit amend message files in .git when running forbid-tabs & co by default HOT 7
- CSS (single line comments) set `//` HOT 1
- insert-license detection does not ignore spaces after comment symbols HOT 4
- chmod hook conflicts with shell chmod in a python virtual env HOT 2
- Is there a way of defining a string in the hooks args instead of --license-filepath HOT 1
- How do I specify the hook to be applied to all files in the repo that ends with .py? HOT 2
- breaking changes in 1.5.2 and 1.5.3 - InvalidManifestError HOT 3
- make `forbid-tabs` and `replace-tabs` accept an exclusion list HOT 4
- Feature Request (insert_license): Use multiline comment for python files HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pre-commit-hooks.