Require explicit FTP over TLS

[radum]

Require explicit FTP over TLS

[lucasmotta]

I am using the node-ftp library and they claim to support FTPS by using the secure flag.
Since I can't reproduce this here (I don't have access to a server with FTPS), do you mind testing this option from node-ftp?
You can read the documentation here, it's pretty simple: https://github.com/mscdex/node-ftp

If it works for you, I can implement the secure flag in DPLOY as well.

[radum]

Yes sure, I will get back to you ASAP with this.

[radum]

Hi @lucasmotta so I've managed to test locally using node-ftp and it works.

All I did was to add these options to the connect method:

secure: true,
secureOptions: {
    rejectUnauthorized: false
}

Complete script here:

var Client = require('ftp');

  var c = new Client();
  c.on('ready', function() {
    console.log('done, I'm connected');
    c.end();
  });

  c.connect({
    host: 'my.server.com',
    port: 21,
    secure: true,
    secureOptions: {
      rejectUnauthorized: false
    },
    user: 'user',
    password: 'pass'
  });

So I guess you can implement the secure flag in DPLOY now, but the rejectUnauthorized is important as well, it won't work without it.

[lucasmotta]

Nice one! I will implement the secure and secureOptions as well.
Thanks for testing this, but I will need your help to test again once it's implemented!

[radum]

Sure, just let me know and I will do it.

Thanks for your support.

[lucasmotta]

Hey @radum, I just released a new version of DPLOY (v1.1.0) with the secure and secureOptions settings.
Let me know if it works, then we can tick this issue as closed.

[radum]

Hey @lucasmotta works like a charm 👍

I just tested now and works great, thanks for the update.

[piotr-cz]

I'd appreciate if the rejectUnauthorized option would be specified in the README.md because it's not clear which secureOptions can be specified without finding this issue.