Comments (9)
@MineCityZolii @CallMeGhosty Could you please try if the recent version fixes this issue? Thank you!
from bungeeguard.
Yes, it works! Thanks for the fast response. I think this issue can be closed now.
Thank you @lucko and @McLive!
from bungeeguard.
Thanks @McLive! :)
from bungeeguard.
I don't have much time to look into this at the moment. Would happily accept a PR fixing it.
from bungeeguard.
Hello, could you look now into the issue?
from bungeeguard.
I suspect the problematic code is here:
https://github.com/SkinsRestorer/SkinsRestorerX/blob/8b3efd5aaa9390ba1e55ca64a77c6d0e64c1168e/src/main/java/skinsrestorer/bungee/SkinApplier.java#L46-L68
Which conflicts with:
https://github.com/lucko/BungeeGuard/blob/master/bungeeguard-proxy/src/main/java/me/lucko/bungeeguard/proxy/SpoofedLoginResult.java
This is something the SkinsRestorer author would need to fix.
from bungeeguard.
@DoNotSpamPls would you be able to give some insight? :)
This code in particular doesn't seem very sane to me.
Creating a totally new LoginResult
seems redundant - could SkinsRestorer not just modify the properties inside of the existing object?
The manipulation of the Property arrays also seems odd - I can't really follow what that code is even meant to be doing?
from bungeeguard.
Hi @lucko, unfortunately I don't develop SkinsRestorer anymore, so I can't help much. However, I'm pinging @McLive here and in DMs, he may be able to assist you.
from bungeeguard.
@lucko Somehow I can't access the LoginResult provided by BungeeGuard...
Property[] present = profile.getProperties();
System.out.println("present props:");
System.out.println(present.toString());
for (Property prop : present) {
System.out.println(prop.getName());
}
System.out.println(present[0]);
17:52:00 [INFORMATION] present props:
17:52:00 [INFORMATION] [Lnet.md_5.bungee.connection.LoginResult$Property;@654a3041
17:52:00 [SCHWERWIEGEND] java.lang.ArrayIndexOutOfBoundsException: 0
17:52:00 [SCHWERWIEGEND] at skinsrestorer.bungee.SkinApplier.applySkin(SkinApplier.java:64)
17:52:00 [SCHWERWIEGEND] at skinsrestorer.bungee.listeners.LoginListener$1.run(LoginListener.java:82)
17:52:00 [SCHWERWIEGEND] at net.md_5.bungee.scheduler.BungeeTask.run(BungeeTask.java:63)
17:52:00 [SCHWERWIEGEND] at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
17:52:00 [SCHWERWIEGEND] at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
17:52:00 [SCHWERWIEGEND] at java.lang.Thread.run(Unknown Source)
Did I miss something?
from bungeeguard.
Related Issues (20)
- SpongeForge error HOT 2
- [1.8.8 FlamePaper] NoClassDefFoundError: TemporaryPlayerFactory HOT 1
- Unable to join HOT 4
- Denying connection from <IP> - - reason: INVALID_HANDSHAKE Spam HOT 1
- BungeeCord 1.20 error HOT 1
- Unable to retrieve domain hostname HOT 1
- Bungeeguard 1.20.x Auth Error
- Server starts successfully and then stops instantly and restarts and this happens in a loop THIS ONLY HAPPENS WHEN BUNGEEGUARD PLUGIN IS IN THE PLUGINS FOLDER HOT 1
- ViaVersion is not working with bungeeGuard! HOT 1
- Running reload command from rcon gives Sorry, this command can only be ran from the console
- Stable version of BungeeGuard isn't updated to fix Spigot compatibility HOT 2
- Kicked whilst connecting to lobby: Unable to authenticate HOT 1
- Can't join Velocity Server with BungeeGuard (Unable to connect to lobby: Unable to authenticate) HOT 1
- In the console it says it doesn't want to start, but otherwise it obviously works
- Clients with 1.19.3 can't connect server HOT 1
- Error while loading HOT 10
- Error when someone joins with no token
- Incompatibility with EaglercraftXBungee HOT 9
- Some error HOT 2
- Error when someone try to join (with valid token) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bungeeguard.