Giter Site home page Giter Site logo

Comments (1)

DrZoddiak avatar DrZoddiak commented on June 10, 2024 1

Linking this issue here since it's somewhat relevant, though there is little discussion. Notably it was marked by Luck as Not planned.
#3729

That said, I'm very partial to maintaining expected behavior, so I believe either option 1 if we're going to engage in this, or 4.

While I don't think it's a particularly valuable contribution to the overall state of the software, I do think it would follow the expected behavior of plugins in general.

If a change like 2 or 3 were to be made, I think there should be a "breaking change" notification and version bump (or during a time where there is) but again these are not favorable options.

I do like the feedback provided, it lets the user know (without checking logs or console) that the plugin is loaded, and what version is loaded, but It isn't particularly valuable in its own right. Users don't need to know what versions of the plugin I'm running or that I have that particular plugin. Though I don't believe in security through obfuscation -- I do think it helps users to have a list of commands that are actually usable.

Many of the users that I've seen come through the discord usually are worried about users stealing their plugins or obfuscating for security concerns, but as the issue I've linked above, that user simply wanted a "clean" command interface, and for that I do see value in making a change.

Overall I think solution 1 would be the most ideal in the situation we're currently in. Allowing backwards compatibility while introducing a long-sought feature in LuckPerms that would also give Luckperms the expected behavior of having permission controlled commands.

The permission shouldn't be much of an issue, I think luckperms.lp would maintain consistency in permission naming, but luckperms.base may not hurt either.

from luckperms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.