PseudoKV

[MeijeSibbel]

PseudoKV

[jkawamoto]

I think it'd be better to call this interface PseudoKVS instead of PseudoS3 because S3 API has more functionalities such as versioning and ACL. Using S3 sounds confusing.

[lukechampine]

To make this slightly more concrete, I was thinking along the lines of:

type PseudoS3 struct { ... }

func (PseudoS3) CreateBucket(name string) (*PseudoBucket, error)
func (PseudoS3) Bucket(name string) (*PseudoBucket, error)

type PseudoBucket struct { ... }

func (PseudoBucket) Put(key, val []byte) error
func (PseudoBucket) Get(key []byte) ([]byte, error)
func (PseudoBucket) Delete(key []byte) error
func (PseudoBucket) Sync() error

The main goal would be to aggregate Puts across the entire PseudoS3 instance, such that data is only flushed to hosts when a full sector's-worth of key-vals have been stored. However, I'm not familiar enough with S3 to flesh out a full API, and I don't have a good idea of what the local storage aspect would look like.

[jkawamoto]

I think it also needs List function, too.

[jkawamoto]

It also would be better if the type of val is io.Reader in both Put and Get instead of []byte. If it uses byte slices, we need to copy each object to heap, and thus we might not be able to store bigger objects.

[MeijeSibbel]

PseudoKV has been integrated, moving new roadmap features to #126 for consistency.

[jkawamoto]

I think PseudoKV isn't done yet.

There are still some missing functions:

us/renter/renterutil/metadb.go

Lines 348 to 354 in 8a2eb34

	// DeleteBlob implements MetaDB.
	func (db *BoltMetaDB) DeleteBlob(key []byte) error {
	return db.bdb.Update(func(tx *bolt.Tx) error {
	// TODO: refcounts
	return tx.Bucket(bucketBlobs).Delete(key)
	})
	}

us/renter/renterutil/metadb.go

Lines 367 to 369 in 8a2eb34

	func (db *BoltMetaDB) UnreferencedSectors() (map[hostdb.HostPublicKey][]crypto.Hash, error) {
	return nil, nil // TODO
	}

Also kv branch is not merged into master.

[MeijeSibbel]

Thanks, reopened. I see this is also related to #102 correct?

[jkawamoto]

Yes, it is. Especially, this problem #102 (comment).